Skip to content

Commit 316d760

Browse files
authored
Merge pull request #12 from event-engine/feature/php8.4-remove-deprecations
Remove php8.4 deprecations
2 parents 0bcab12 + 91c117a commit 316d760

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/AggregateStateStore.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ interface AggregateStateStore
2222
* @return mixed State of the aggregate
2323
* @throws AggregateNotFound
2424
*/
25-
public function loadAggregateState(string $aggregateType, string $aggregateId, int $expectedVersion = null);
25+
public function loadAggregateState(string $aggregateType, string $aggregateId, ?int $expectedVersion = null);
2626

2727
/**
2828
* @param string $aggregateType

src/InnerDocumentStore.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,23 +210,23 @@ public function getPartialDoc(string $collectionName, PartialSelect $partialSele
210210
/**
211211
* @inheritDoc
212212
*/
213-
public function filterDocs(string $collectionName, Filter $filter, int $skip = null, int $limit = null, OrderBy $orderBy = null): \Traversable
213+
public function filterDocs(string $collectionName, Filter $filter, ?int $skip = null, ?int $limit = null, ?OrderBy $orderBy = null): \Traversable
214214
{
215215
return $this->documentStore->filterDocs($collectionName, $filter, $skip, $limit, $orderBy);
216216
}
217217

218218
/**
219219
* @inheritDoc
220220
*/
221-
public function findDocs(string $collectionName, Filter $filter, int $skip = null, int $limit = null, OrderBy $orderBy = null): \Traversable
221+
public function findDocs(string $collectionName, Filter $filter, ?int $skip = null, ?int $limit = null, ?OrderBy $orderBy = null): \Traversable
222222
{
223223
return $this->documentStore->findDocs($collectionName, $filter, $skip, $limit, $orderBy);
224224
}
225225

226226
/**
227227
* @inheritDoc
228228
*/
229-
public function findPartialDocs(string $collectionName, PartialSelect $partialSelect, Filter $filter, int $skip = null, int $limit = null, OrderBy $orderBy = null): \Traversable
229+
public function findPartialDocs(string $collectionName, PartialSelect $partialSelect, Filter $filter, ?int $skip = null, ?int $limit = null, ?OrderBy $orderBy = null): \Traversable
230230
{
231231
return $this->documentStore->findPartialDocs($collectionName, $partialSelect, $filter, $skip, $limit, $orderBy);
232232
}

src/InnerEventStore.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function loadAggregateEvents(
4949
string $aggregateType,
5050
string $aggregateId,
5151
int $minVersion = 1,
52-
int $maxVersion = null
52+
?int $maxVersion = null
5353
): \Iterator {
5454
return $this->eventStore->loadAggregateEvents(
5555
$streamName,

0 commit comments

Comments
 (0)