Better Offline resize handling

+ podman build files

Author: Sapd

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [Unreleased]
+
+### Improvements
+
+* Volume Expansion: Set capability to OFFLINE for proper offline expansion behavior and provide error message
+
 ## v0.31.2
 
 ### Improvements

Makefile

@@ -46,3 +46,7 @@ include go.mk/public.mk
 # Docker
 go.mk/init.mk:
 include Makefile.docker
+
+# Podman
+go.mk/init.mk:
+include Makefile.podman

Makefile.podman

@@ -0,0 +1,25 @@
+go.mk/version.mk:
+include go.mk/version.mk
+
+# Default to same image as docker, but allow override with CSI_IMAGE env var
+CSI_IMAGE ?= exoscale/csi-driver
+# Allow overriding the latest tag behavior
+CSI_TAG ?= latest
+
+.PHONY: podman
+podman:
+	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 $(MAKE) build
+	podman build --platform linux/amd64 --rm \
+	  -t ${CSI_IMAGE}:${CSI_TAG} \
+	  --build-arg VERSION="${VERSION}" \
+	  --build-arg VCS_REF="${GIT_REVISION}" \
+	  --build-arg BUILD_DATE="$(shell date -u +"%Y-%m-%dT%H:%M:%SZ")" \
+	  -f ./Dockerfile \
+	  bin/
+	podman tag ${CSI_IMAGE}:${CSI_TAG} ${CSI_IMAGE}:${VERSION}
+
+.PHONY: podman-push
+podman-push:
+	podman push ${CSI_IMAGE}:${CSI_TAG} \
+	  && podman push ${CSI_IMAGE}:${VERSION}
+

README.md

@@ -70,10 +70,20 @@ make build
 ```
 
 Or you can build a container image
+
+### Using Docker
 ```Bash
 make docker
 ```
 
+### Using Podman
+```Bash
+gmake podman
+# Override: CSI_IMAGE=myregistry/image CSI_TAG=v1.0.0 gmake podman
+```
+
+**Note**: Podman explicitly targets `linux/amd64` for compatibility when building on ARM64 Macs for Intel Kubernetes nodes. The CSI driver works without this targeting, but some filesystem features like volume expansion require proper architecture matching.
+
 ## Versioning and compatibility policy
 
 The Exoscale CSI adheres to [Semantic Versioning](https://semver.org/).

driver/controller.go

@@ -691,7 +691,7 @@ func (d *controllerService) ControllerExpandVolume(ctx context.Context, req *csi
 		return nil, err
 	}
 
-	_, err = client.GetBlockStorageVolume(ctx, volumeID)
+	volume, err := client.GetBlockStorageVolume(ctx, volumeID)
 	if err != nil {
 		if errors.Is(err, v3.ErrNotFound) {
 			return nil, status.Errorf(codes.NotFound, "volume %s not found", volumeID)
@@ -718,6 +718,13 @@ func (d *controllerService) ControllerExpandVolume(ctx context.Context, req *csi
 		return nil, status.Errorf(codes.OutOfRange, "invalid capacity range: %v", err)
 	}
 
+	// Check if volume is attached to any instance
+	if volume.Instance != nil && volume.Instance.ID != "" {
+		instanceInfo := fmt.Sprintf(" (attached to instance %s)", volume.Instance.ID)
+		return nil, status.Error(codes.FailedPrecondition, 
+			"Volume must be detached before expanding"+instanceInfo+". Scale down workloads using this PVC, then resize will complete automatically once Kubernetes retries.")
+	}
+
 	if newSizeInBytes%GiB != 0 {
 		msg := "requested size in bytes cannot be exactly converted to GiB: %d"
 

driver/identity.go

@@ -42,7 +42,7 @@ func (d *Driver) GetPluginCapabilities(ctx context.Context, req *csi.GetPluginCa
 			{
 				Type: &csi.PluginCapability_VolumeExpansion_{
 					VolumeExpansion: &csi.PluginCapability_VolumeExpansion{
-						Type: csi.PluginCapability_VolumeExpansion_ONLINE,
+						Type: csi.PluginCapability_VolumeExpansion_OFFLINE,
 					},
 				},
 			},