Fix/tool call accuracy (#2079) #2092
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sdivye92
commented
Jun 26, 2025
sdivye92
commented
- Fix ToolCallAccuracy returns score higher than 1.0 (ToolCallAccuracy returns score higher than 1.0 #2079)
- Using zip to combine reference_tool_calls and pred_tool_calls
- Updated is_sequence_aligned method to check for same len of pred and ref seq
- This fixes issue when tool call accuracy is 1 even when pred_tool_calls has more tool calls than reference_tool_calls.
- equal check between pred_sequence and ref_sequence will check that both should be same length.
- when equal order of occurence of their elements are same.
- equal check between pred_sequence and ref_sequence will check that both should be same length - when equal order of occurence of their elements are same
dosubot
bot
added
the
size:S
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed critical scoring bug in ToolCallAccuracy metric where it could incorrectly return scores higher than 1.0 due to double-counting matches.
- Modified
ragas/src/ragas/metrics/_tool_call_accuracy.pyto usezip()for one-to-one matching between reference and prediction tool calls - Updated
is_sequence_alignedto enforce equal lengths between prediction and reference sequences - Added validation to ensure tool calls are made in correct order and quantity
- Fixed edge case where perfect scores were given despite extra predicted tool calls
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
|
Thanks for the PR @sdivye92 Some additional things needs to be added before we can merge:
|
Merged
|
Taken up in #2300 |
anistark
added a commit
that referenced
this pull request
Sep 22, 2025
## Issue Link / Problem Description <!-- Link to related issue or describe the problem this PR solves --> - contd #2092 --------- Co-authored-by: sdivye92 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.