Task/fix boy animation #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ystrot
requested changes
Dec 18, 2018
|
|
||
| class ShapeAnimation: AnimationImpl<Shape> { | ||
| convenience init(animatedNode: Shape, finalValue: Shape, animationDuration: Double, delay: Double = 0.0, autostart: Bool = false, fps: UInt = 30) { | ||
| let toParentGlobalTransfrom: Transform? |
Member
There was a problem hiding this comment.
Again no need to use optional property when you have great default value and it's actually used everywhere.
Source/animation/types/animation_generators/CombinationAnimationGenerator.swift
Outdated
Show resolved
Hide resolved
Source/animation/types/animation_generators/CombinationAnimationGenerator.swift
Outdated
Show resolved
Hide resolved
Source/animation/types/animation_generators/CombinationAnimationGenerator.swift
Outdated
Show resolved
Hide resolved
ystrot
reviewed
Dec 20, 2018
| let fromPos = parentPos.concat(with: to.place) | ||
| let toPos = parentPos.concat(with: to.place) | ||
| let fromPos = parentPos.concat(with: from.place) | ||
| let toParentPos = animation.toParentGlobalTransfrom ?? parentPos |
Member
There was a problem hiding this comment.
Is this still valid? Looks like ?? can be avoided.
f3dm76
force-pushed
the
task/fix-boy-animation
branch
from
8561348 to
b4510d3
Compare
Extra optional Fix
ystrot
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.