wip on Fix 387 - add "system" color support for SVG parser #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mgoldin
commented
Feb 28, 2019
mgoldin
commented
ystrot
requested changes
Mar 18, 2019
Member
ystrot
left a comment
ystrot
left a comment
There was a problem hiding this comment.
There are few comments. Once they will be addressed, you may add a test case and I'll merge it.
| let green = CGFloat((rgbValue >> 08) & 0xff) | ||
| let blue = CGFloat((rgbValue >> 00) & 0xff) | ||
|
|
||
Member
There was a problem hiding this comment.
Looks like you don't use SwiftLint. Please install it to make sure there is no formatting issues.
added 2 commits
April 5, 2019 13:06
…lorProp04 to MacawSVGTests
ystrot
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.