Remove Dupes button doesn't exist on window toolbar even though it installed correctly

[harryfine]

I'm on 140.4.0esr (64-bit) on LInux, and the extension installed perfectly, but I didn't see it on the UI anywhere, or in any menus. I stopped and re-started TB, still not there.

I looked under Tools in the hamburger menu. Not there. Then for fun I turned on the menu bar which is normally off, and it showed under Tools. Crazy. But it worked.

I'm using TB under Linux. This can cause a lot of confusion for people who don't realize the remove dupes button is not hidden on the menu bar. By the way, amazing addon. My folders were a mess with duplicates.

[eyalroz]

You are absolutely right - there needs to be a toolbar button for removing duplicates. And, in fact, there used to be - until TB scuttled the toolbar. It replaced it with something that is sort-of like a toolbar, but not quite; and most importantly - cannot be reasonably overlayed, like regular UI elements in the application. You may have noticed that my release pages, e.g.:

https://github.com/eyalroz/removedupes/releases/tag/v0.6.5-b1

mention this as a problem. I am currently unable to arrange for such a toolbar button to exist.

Also, I find it quite inappropriate that TB defaults to showing a hamburger menu, but not the actual menu bar - as though it was a smartphone app rather than a desktop application. But even regardless of that: Here, have a look, this is the XML for the hamburger menu:

<toolbarbutton xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="button-appmenu" type="menu" badged="true" class="button toolbar-button button-appmenu" label="AppMenu" tooltiptext="Display the Thunderbird Menu" tabindex="0">
  <stack class="toolbarbutton-badge-stack"><image class="toolbarbutton-icon" label="AppMenu" type="menu"/>
    <html:label xmlns:html="http://www.w3.org/1999/xhtml" class="toolbarbutton-badge">
    </html:label>
  </stack>
  <label class="toolbarbutton-text" crop="end" flex="1" value="AppMenu"/>
</toolbarbutton>

Do you see any menu items? Submenus? No, there's nothing. That's one way to make the UI non-extensible: You make the XML fully dynamically-generated, and thus - extensions can't touch the menu when the window comes up; it is implicit in some piece of code, instead of having the form of hidden, but fully-formed, XML. And thus, I am stumped.

Unfortunately, I expect more of Thunderbird to go down this route.