From 0155b00ec4c8107b0c24680f7c58a0d660dabfa8 Mon Sep 17 00:00:00 2001 From: tobias-tengler <45513122+tobias-tengler@users.noreply.github.com> Date: Thu, 10 Apr 2025 15:14:12 +0200 Subject: [PATCH 1/2] Forward emit_semantic_types to raw_response_visit_inline_fragment --- compiler/crates/relay-typegen/src/visit.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/compiler/crates/relay-typegen/src/visit.rs b/compiler/crates/relay-typegen/src/visit.rs index bf0978b0b1daa..ebf712c115d89 100644 --- a/compiler/crates/relay-typegen/src/visit.rs +++ b/compiler/crates/relay-typegen/src/visit.rs @@ -2324,10 +2324,7 @@ pub(crate) fn raw_response_visit_selections( runtime_imports, custom_scalars, enclosing_linked_field_concrete_type, - inline_fragment - .directives - .named(*THROW_ON_FIELD_ERROR_DIRECTIVE) - .is_some(), + emit_semantic_types, ), Selection::LinkedField(linked_field) => { // Note: We intentionally use the semantic field type here From 3e7bd39c64a3709d1daa2dd800aedf9d81a12ab9 Mon Sep 17 00:00:00 2001 From: tobias-tengler <45513122+tobias-tengler@users.noreply.github.com> Date: Thu, 10 Apr 2025 15:20:53 +0200 Subject: [PATCH 2/2] Update test snapshots --- .../fixtures/semantic_non_null_in_raw_response.expected | 8 ++++---- .../fixtures/semantic_non_null_in_raw_response.expected | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/compiler/crates/relay-typegen/tests/generate_flow/fixtures/semantic_non_null_in_raw_response.expected b/compiler/crates/relay-typegen/tests/generate_flow/fixtures/semantic_non_null_in_raw_response.expected index 096130def163f..d32afeedb6262 100644 --- a/compiler/crates/relay-typegen/tests/generate_flow/fixtures/semantic_non_null_in_raw_response.expected +++ b/compiler/crates/relay-typegen/tests/generate_flow/fixtures/semantic_non_null_in_raw_response.expected @@ -29,14 +29,14 @@ export type MyQuery$data = {| |}; export type MyQuery$rawResponse = {| +opera?: ?{| - +cast: ?$ReadOnlyArray, - +composer: ?{| + +composer: {| +id: string, +name: ?string, |}, diff --git a/compiler/crates/relay-typegen/tests/generate_typescript/fixtures/semantic_non_null_in_raw_response.expected b/compiler/crates/relay-typegen/tests/generate_typescript/fixtures/semantic_non_null_in_raw_response.expected index d531b42780369..5fdb7656ddce5 100644 --- a/compiler/crates/relay-typegen/tests/generate_typescript/fixtures/semantic_non_null_in_raw_response.expected +++ b/compiler/crates/relay-typegen/tests/generate_typescript/fixtures/semantic_non_null_in_raw_response.expected @@ -30,16 +30,16 @@ export type MyQuery$data = { export type MyQuery$rawResponse = { readonly opera?: { readonly cast: ReadonlyArray<{ - readonly character: string | null | undefined; + readonly character: string; readonly singer: { readonly id: string; readonly name: string | null | undefined; - } | null | undefined; - } | null | undefined> | null | undefined; + }; + }>; readonly composer: { readonly id: string; readonly name: string | null | undefined; - } | null | undefined; + }; } | null | undefined; }; export type MyQuery = {