Skip to content

Bugfix: Prevent model weights file duplicate to cache #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bugfix: Prevent model weights file duplicate to cache #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion dinov3/hub/backbones.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,21 @@
from enum import Enum
from typing import List, Optional, Union
from urllib.parse import urlparse
from urllib.request import url2pathname
from pathlib import Path

import torch

from .utils import DINOV3_BASE_URL

LOADERS = {
"file": lambda url, **_: torch.load(
Path(url2pathname(urlparse(url).path)), map_location="cpu", weights_only=True
),
"http": lambda url, **kwargs: torch.hub.load_state_dict_from_url(url, map_location="cpu", **kwargs),
"https": lambda url, **kwargs: torch.hub.load_state_dict_from_url(url, map_location="cpu", **kwargs),
}


class Weights(Enum):
LVD1689M = "LVD1689M"
Expand All @@ -30,6 +39,18 @@ def convert_path_or_url_to_url(path: str) -> str:
return Path(path).expanduser().resolve().as_uri()


def _load_state_dict(url: str, check_hash: bool = False) -> dict[str, torch.Tensor]:
scheme = urlparse(url).scheme
if scheme not in LOADERS:
raise ValueError(
f"Unsupported URL scheme: {scheme}. Supported schemes are: {', '.join(LOADERS.keys())}."
)

loader = LOADERS[scheme]
kwargs = {"check_hash": check_hash} if scheme in ("http", "https") else {}
return loader(url, **kwargs)


def _make_dinov3_vit_model_arch(
*,
patch_size: int = 16,
Expand Down Expand Up @@ -137,7 +158,7 @@ def _make_dinov3_vit(
)
else:
url = convert_path_or_url_to_url(weights)
state_dict = torch.hub.load_state_dict_from_url(url, map_location="cpu", check_hash=check_hash)
state_dict = _load_state_dict(url, check_hash=check_hash)
model.load_state_dict(state_dict, strict=True)
else:
model.init_weights()
Expand Down