-
Notifications
You must be signed in to change notification settings - Fork 323
Open
Description
Hi! Really enjoying the code and the paper. These are the most comprehensive resources on flow matching.
I noticed that the text modeling example might contain a subpar encoding of timesteps. In short, it uses the default max_period parameter from the GLIDE repository, which is a diffusion model with discrete timesteps in the range {0, 1, 2, ...}. However, as I understand correctly, in your example, all timesteps are sampled from the [0, 1] time horizon. See the similar issue that I've opened in the SiT repository. I think the most elegant solution is to rescale the timesteps similar to how Flux handles them.
Let me know if I am misunderstanding something, as I am just on my way of learning the flow matching framework.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels