Skip to content

Commit 0373d93

Browse files
jeongseok-metameta-codesync[bot]
authored andcommitted
Fix CQS signal readability-static-definition-in-anonymous-namespace in arvr/libraries/pymomentum/tensor_ik (#724)
Summary: Pull Request resolved: #724 Pull Request resolved: #696 Reviewed By: cstollmeta Differential Revision: D85124503 fbshipit-source-id: 6ae2ba67d98d66e3492bf6b545417d8e35fe6e93
1 parent 35271c3 commit 0373d93

File tree

5 files changed

+16
-16
lines changed

5 files changed

+16
-16
lines changed

pymomentum/tensor_ik/tensor_diff_pose_prior_error_function.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ class TensorDiffPosePriorErrorFunction : public TensorErrorFunction<T> {
3737
size_t /* unused nFrames */) const override;
3838
};
3939

40-
const static int NMIXTURES_IDX = -1;
41-
const static int NPARAMETERS_IDX = -2;
42-
const static int NCOMPONENTS_IDX = -3;
40+
const int NMIXTURES_IDX = -1;
41+
const int NPARAMETERS_IDX = -2;
42+
const int NCOMPONENTS_IDX = -3;
4343

4444
template <typename T>
4545
TensorDiffPosePriorErrorFunction<T>::TensorDiffPosePriorErrorFunction(

pymomentum/tensor_ik/tensor_distance_error_function.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ using momentum::FullyDifferentiableDistanceErrorFunctionT;
2121

2222
namespace {
2323

24-
const static int NCONS_IDX = -1;
24+
const int NCONS_IDX = -1;
2525

2626
template <typename T>
2727
class TensorDistanceErrorFunction : public TensorErrorFunction<T> {

pymomentum/tensor_ik/tensor_projection_error_function.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ using momentum::FullyDifferentiableProjectionErrorFunctionT;
2020

2121
namespace {
2222

23-
const static int NCONS_IDX = -1;
23+
const int NCONS_IDX = -1;
2424

2525
template <typename T>
2626
class TensorProjectionErrorFunction : public TensorErrorFunction<T> {

pymomentum/tensor_ik/tensor_vertex_error_function.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ namespace pymomentum {
1616

1717
namespace {
1818

19-
const static int NCONS_IDX = -1;
20-
static constexpr const char* kVerticesName = "vertices";
21-
static constexpr const char* kWeightsName = "weights";
22-
static constexpr const char* kTargetPositionsName = "target_positions";
23-
static constexpr const char* kTargetNormalsName = "target_normals";
24-
static constexpr const char* kTypeName = "type";
19+
const int NCONS_IDX = -1;
20+
constexpr const char* kVerticesName = "vertices";
21+
constexpr const char* kWeightsName = "weights";
22+
constexpr const char* kTargetPositionsName = "target_positions";
23+
constexpr const char* kTargetNormalsName = "target_normals";
24+
constexpr const char* kTypeName = "type";
2525

2626
template <typename T>
2727
class TensorVertexErrorFunction : public TensorErrorFunction<T> {

pymomentum/tensor_ik/tensor_vertex_projection_error_function.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ namespace pymomentum {
1616

1717
namespace {
1818

19-
const static int NCONS_IDX = -1;
20-
static constexpr const char* kVerticesName = "vertices";
21-
static constexpr const char* kWeightsName = "weights";
22-
static constexpr const char* kTargetPositionsName = "target_positions";
23-
static constexpr const char* kProjectionsName = "projections";
19+
const int NCONS_IDX = -1;
20+
constexpr const char* kVerticesName = "vertices";
21+
constexpr const char* kWeightsName = "weights";
22+
constexpr const char* kTargetPositionsName = "target_positions";
23+
constexpr const char* kProjectionsName = "projections";
2424

2525
template <typename T>
2626
class TensorVertexProjectionErrorFunction : public TensorErrorFunction<T> {

0 commit comments

Comments
 (0)