You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix PyPI publishing: Add missing auditwheel repair step for Linux wheels (#738)
Summary:
PyPI was rejecting Linux wheels with [error](https://github.com/facebookresearch/momentum/actions/runs/18853730732/job/53797928855):
`Binary wheel 'pymomentum_cpu-0.1.81.post0-cp312-cp312-linux_x86_64.whl' has an unsupported platform tag 'linux_x86_64'.`
PyPI requires Linux wheels to use `manylinux` tags (e.g., `manylinux_2_17_x86_64`) instead of generic `linux_x86_64` for cross-distribution compatibility.
The `build_pypi_repair` task was already defined in `pixi.toml` since PR #725, but the CI workflow never called it. This wasn't caught because:
* CI builds wheels successfully without publishing (no PyPI validation)
* First actual PyPI publish attempt revealed the issue
Added `build_pypi_repair` step to CI workflow after building wheels on Linux:
* Runs `auditwheel repair` to convert `linux_x86_64` → `manylinux_*` tags
* Removes original wheel after repair
* Skipped on macOS (not needed)
## Checklist:
- [ ] Adheres to the [style guidelines](https://facebookresearch.github.io/momentum/docs/developer_guide/style_guide)
- [ ] Codebase formatted by running `pixi run lint`
Pull Request resolved: #738
Test Plan: Next PyPI publish should succeed with properly tagged `manylinux` wheels.
Reviewed By: nickyhe-gemini
Differential Revision: D85597200
Pulled By: jeongseok-meta
fbshipit-source-id: 10eb68baa893f5e5d31ddab61f8d55deb39df71d
0 commit comments