Skip to content

Commit 4395dc8

Browse files
cdtwiggfacebook-github-bot
authored andcommitted
to_gltf renamed to save_gltf_to_dict. (#570)
Summary: This naming was a bit confusing because there are many to_gltf functions, so let's specify that we're converting it to a Dict. Reviewed By: jeongseok-meta Differential Revision: D82411874
1 parent 9ee173f commit 4395dc8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pymomentum/geometry/geometry_pybind.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ PYBIND11_MODULE(geometry, m) {
236236
//
237237
// [static methods for io]
238238
// - load_gltf_from_bytes(gltf_btyes)
239-
// - to_gltf(character, fps, motion, offsets)
239+
// - save_gltf_to_dict(character, fps, motion, offsets)
240240
// - load_fbx(fbxFilename, modelFilename, locatorsFilename)
241241
// - load_fbx_from_bytes(fbx_bytes, permissive)
242242
// - load_fbx_with_motion(fbxFilename, permissive)
@@ -689,7 +689,7 @@ Note: In practice, most limits are enforced on the model parameters, but momentu
689689
py::arg("gltf_bytes"))
690690
// toGLTF(character, fps, motion)
691691
.def_static(
692-
"to_gltf",
692+
"save_gltf_to_dict",
693693
&toGLTF,
694694
py::call_guard<py::gil_scoped_release>(),
695695
R"(Serialize a character as a GLTF using dictionary form.

0 commit comments

Comments
 (0)