Skip to content

Commit fc37207

Browse files
cdtwiggfacebook-github-bot
authored andcommitted
Add new TRS functionality. (#580)
Summary: Pull Request resolved: #580 We are finding that many users of the PyMomentum library prefer the use of rotation matrices to quaternions because rotation matrices tend to function better in ML learning algorithms. However the existing skel_state matrix functionality converts to 4x4 matrices which is challenging to work with because scale has been baked into the matrix and needs to be removed. Therefore we decided it likely make sense to have support for a TRS format that stores separate translations, 3x3 rotations, and uniform scales. This format can be easily converted to-and-from skel_states, and is generally safer to work with than 4x4 matrices (for example inversion just involves a transpose). Reviewed By: jeongseok-meta Differential Revision: D82840072 fbshipit-source-id: 22b8d2d4294231a7af5fccbb72c9f0243d54a479
1 parent 3d48575 commit fc37207

File tree

3 files changed

+912
-0
lines changed

3 files changed

+912
-0
lines changed

pymomentum/cmake/build_variables.bzl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,10 @@ skel_state_sources = [
135135
"skel_state.py",
136136
]
137137

138+
trs_sources = [
139+
"trs.py",
140+
]
141+
138142
marker_tracking_public_headers = [
139143
]
140144

0 commit comments

Comments
 (0)