Hide loader fixes

Author: faisalnjs

src/clicker/clicker.js

@@ -342,6 +342,7 @@ try {
     storage.set("makeUpDate", null);
     auth.syncPush("makeUpDate");
     ui.view("");
+    ui.stopLoader();
   });
 
   // Submit to Google Forms
@@ -440,6 +441,7 @@ try {
         {
           text: "Continue Anyway",
           close: true,
+          onclick: ui.stopLoader,
         },
       ]);
     } else if (matchesCurrentPeriod && storage.get("makeUpDate")) {
@@ -452,11 +454,13 @@ try {
             auth.syncPush("makeUpDate");
             ui.updateTitles();
             ui.view("");
+            ui.stopLoader();
           },
         },
         {
           text: "Continue Anyway",
           close: true,
+          onclick: ui.stopLoader,
         },
       ]);
     }
@@ -557,7 +561,6 @@ try {
       });
     } catch (error) {
       console.error(error);
-      ui.view("api-fail");
     }
   }
 

src/modules/auth.js

@@ -62,7 +62,6 @@ export async function sync(hideWelcome = true, returnFunction = null) {
         continueWithoutAPIButton.addEventListener("click", () => {
             ui.view();
             returnFunction();
-            ui.stopLoader();
             const newContinueWithoutAPIButton = continueWithoutAPIButton.cloneNode(true);
             continueWithoutAPIButton.parentNode.replaceChild(newContinueWithoutAPIButton, continueWithoutAPIButton);
         });

src/modules/ui.js

@@ -397,11 +397,12 @@ export function view(path = "") {
       });
   }
   const previous = pages.slice(0, pages.length - 1).join("/");
-  const buttons = (title === 'API Offline') ? [] : [
+  const buttons = (path === "api-fail") ? [] : [
     {
       text: `<i class="bi bi-x-lg"></i>`,
       class: "icon",
       close: true,
+      onclick: stopLoader,
     },
   ];
   if (previous) {
@@ -442,6 +443,7 @@ export function view(path = "") {
         document.getElementById("date-input").focus();
       }
       updateTitles();
+      stopLoader();
     });
     const dismissMmakeupClickButton = document.getElementById("dismiss-makeup-button");
     const newDismissMmakeupClickButton = dismissMmakeupClickButton.cloneNode(true);
@@ -451,6 +453,7 @@ export function view(path = "") {
       auth.syncPush("makeUpDate");
       updateTitles();
       view("");
+      stopLoader();
     });
   }
   const event = new Event("view");