Skip to content

Commit 39e6df5

Browse files
committed
fix: missing tests for setMigrator
1 parent 83496c8 commit 39e6df5

File tree

2 files changed

+82
-0
lines changed

2 files changed

+82
-0
lines changed

test/IdRegistry/IdRegistry.migration.t.sol

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ contract IdRegistryTest is IdRegistryTestSuite {
3232
event AdminReset(uint256 indexed fid);
3333
event SetIdCounter(uint256 oldCounter, uint256 newCounter);
3434
event FreezeIdGateway(address idGateway);
35+
event SetMigrator(address oldMigrator, address newMigrator);
3536

3637
/*//////////////////////////////////////////////////////////////
3738
PARAMETERS
@@ -53,6 +54,46 @@ contract IdRegistryTest is IdRegistryTestSuite {
5354
assertEq(idRegistry.isMigrated(), false);
5455
}
5556

57+
/*//////////////////////////////////////////////////////////////
58+
SET MIGRATOR
59+
//////////////////////////////////////////////////////////////*/
60+
61+
function testFuzzOwnerCanSetMigrator(address migrator) public {
62+
address oldMigrator = idRegistry.migrator();
63+
64+
vm.expectEmit();
65+
emit SetMigrator(oldMigrator, migrator);
66+
vm.prank(owner);
67+
idRegistry.setMigrator(migrator);
68+
69+
assertEq(idRegistry.migrator(), migrator);
70+
}
71+
72+
function testFuzzSetMigratorRevertsWhenMigrated(address migrator) public {
73+
address oldMigrator = idRegistry.migrator();
74+
75+
vm.prank(oldMigrator);
76+
idRegistry.migrate();
77+
78+
vm.prank(owner);
79+
vm.expectRevert(IMigration.AlreadyMigrated.selector);
80+
idRegistry.setMigrator(migrator);
81+
82+
assertEq(idRegistry.migrator(), oldMigrator);
83+
}
84+
85+
function testFuzzSetMigratorRevertsWhenUnpaused(address migrator) public {
86+
address oldMigrator = idRegistry.migrator();
87+
88+
vm.startPrank(owner);
89+
idRegistry.unpause();
90+
vm.expectRevert("Pausable: not paused");
91+
idRegistry.setMigrator(migrator);
92+
vm.stopPrank();
93+
94+
assertEq(idRegistry.migrator(), oldMigrator);
95+
}
96+
5697
/*//////////////////////////////////////////////////////////////
5798
MIGRATION
5899
//////////////////////////////////////////////////////////////*/

test/KeyRegistry/KeyRegistry.migration.t.sol

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ contract KeyRegistryTest is KeyRegistryTestSuite {
3333
event Remove(uint256 indexed fid, bytes indexed key, bytes keyBytes);
3434
event AdminReset(uint256 indexed fid, bytes indexed key, bytes keyBytes);
3535
event Migrated(uint256 indexed migratedAt);
36+
event SetMigrator(address oldMigrator, address newMigrator);
3637

3738
function testInitialGracePeriod() public {
3839
assertEq(keyRegistry.gracePeriod(), 1 days);
@@ -50,6 +51,46 @@ contract KeyRegistryTest is KeyRegistryTestSuite {
5051
assertEq(keyRegistry.isMigrated(), false);
5152
}
5253

54+
/*//////////////////////////////////////////////////////////////
55+
SET MIGRATOR
56+
//////////////////////////////////////////////////////////////*/
57+
58+
function testFuzzOwnerCanSetMigrator(address migrator) public {
59+
address oldMigrator = keyRegistry.migrator();
60+
61+
vm.expectEmit();
62+
emit SetMigrator(oldMigrator, migrator);
63+
vm.prank(owner);
64+
keyRegistry.setMigrator(migrator);
65+
66+
assertEq(keyRegistry.migrator(), migrator);
67+
}
68+
69+
function testFuzzSetMigratorRevertsWhenMigrated(address migrator) public {
70+
address oldMigrator = keyRegistry.migrator();
71+
72+
vm.prank(oldMigrator);
73+
keyRegistry.migrate();
74+
75+
vm.prank(owner);
76+
vm.expectRevert(IMigration.AlreadyMigrated.selector);
77+
keyRegistry.setMigrator(migrator);
78+
79+
assertEq(keyRegistry.migrator(), oldMigrator);
80+
}
81+
82+
function testFuzzSetMigratorRevertsWhenUnpaused(address migrator) public {
83+
address oldMigrator = keyRegistry.migrator();
84+
85+
vm.startPrank(owner);
86+
keyRegistry.unpause();
87+
vm.expectRevert("Pausable: not paused");
88+
keyRegistry.setMigrator(migrator);
89+
vm.stopPrank();
90+
91+
assertEq(keyRegistry.migrator(), oldMigrator);
92+
}
93+
5394
/*//////////////////////////////////////////////////////////////
5495
MIGRATION
5596
//////////////////////////////////////////////////////////////*/

0 commit comments

Comments
 (0)