fix server error

Author: sailendraw

composer.json

@@ -2,7 +2,7 @@
     "name": "fatfish/notification",
     "description": "Notification plugin for craft 3.x",
     "type": "craft-plugin",
-    "version": "1.0.5.9-beta",
+    "version": "1.1.0-beta",
     "keywords": [
         "craft",
         "cms",

src/controllers/ServerStatusController.php

@@ -23,30 +23,32 @@ class ServerStatusController extends Controller
         public static function check_server_status()
         {
             $serverxml = CRAFT_BASE_PATH."/storage/notification/server.xml";
-            $SystemXml = CRAFT_BASE_PATH."/storage/notification/server.xml";
+            $SystemXml = CRAFT_BASE_PATH."/storage/notification/system.xml";
             if(!file_exists($SystemXml) || !file_exists($serverxml))
             {
                 syslog(1,"Required file doesnot exist");
                 exit;
             }
-
             $xml = simplexml_load_file($SystemXml);
-            $SystemSlack = $xml->Server->Slack;
-            $SystemEmail = $xml->Server->Email;
+            $SystemSlack = (array)$xml->Server->Slack;
+            $SystemEmail = (array)$xml->Server->Email;
             $serverXml  = simplexml_load_file($serverxml);
-
             foreach ($serverXml as $server) {
-                $ip=gethostbyname($server->server_ip);
+                $ip=gethostbyaddr($server->server_ip);
                 $fp = @fsockopen($ip, (int)$server->port, $err, $errstr);
                 if (!$fp) {
-                    $data = ['text'=>'Service running on port '.$server->server_port.' is Offline'];
-                    ServerNotificationService::UpdateServerStatus($server->id, 0);
-                    SendNotificationMessageService::sendSlackMessage(json_encode($data), $server->port, $SystemSlack);
-                    SendNotificationMessageService::sendEmail($data, $SystemEmail);
+                    $data = ['text'=>'Service running on port '.$server->port.' is Offline'];
+                    ServerNotificationService::UpdateServerStatus((int)$server->id, 0);
+                    if(sizeof($SystemSlack)<0) {
+                        SendNotificationMessageService::sendSlackMessage(json_encode($data),$server->port,$SystemSlack[0]);
+                    }
+                    if(sizeof($SystemEmail)<0) {
+                        SendNotificationMessageService::sendEmail($data,$SystemEmail[0]);
+                    }
 
                 }else
                 {
-                    ServerNotificationService::UpdateServerStatus($server->id, 1);
+                    ServerNotificationService::UpdateServerStatus((int)$server->id, 1);
                 }
             }
 

src/templates/index.twig

@@ -120,7 +120,7 @@
                     <td>{{ server.server_name }}</td>
                     <td>{{ server.server_port }}</td>
                     <td>{{ server.server_threshold }}</td>
-                    <td>{% if server.server_status is defined and server.server_status is null %}<span class="status off "></span>Offline{% else %} <span class="status on"></span>Online{% endif %}</td>
+                    <td>{% if server.server_status is defined and server.server_status==(0) %}<span class="status off "></span>Offline{% else %} <span class="status on"></span>Online{% endif %}</td>
                     <td>{% if server.server_last_check is defined and server.server_last_check is not null %}{{ server.server_last_check }} Min Ago {% else %} 0 Min Ago {% endif %}</td>
                     <td><a href="/admin/notification/edit/{{ server.id }}"> Edit</a> &nbsp; <a href="/admin/notification/delete/{{ server.id }}">Delete</a></td>
                 </tr>