-
Notifications
You must be signed in to change notification settings - Fork 75
Open
Description
The following code calls filterQuery
just to get the pagination. It then calls paramsToAdapter
which calls filterQuery
again.
feathers-sequelize/src/adapter.ts
Line 260 in 320e2b0
const { paginate } = this.filterQuery(params) |
Instead, that line should just use this.options.paginate
. This may seem like a micro-optimization, but I am extending the filterQuery
method in a way that may traverse/clone the query multiple times, even stuff like id: { $in: [...many ids] }
will cause many loops/clones.
fratzinger
Metadata
Metadata
Assignees
Labels
No labels