Merge tag '1.9.5' into 1.10-maintenance

Fedify 1.9.5

Author: dahlia

CHANGES.md

@@ -8,6 +8,15 @@ Version 1.10.3
 
 To be released.
 
+### @fedify/fedify
+
+ -  Fixed `traverseCollection()` yielding no items when a `Collection` has
+    an inline `CollectionPage` in its `first` property without an explicit
+    `id`.  This is common in Mastodon's `replies` collections.  The function
+    previously used `collection.firstId` to determine pagination, which
+    returned `null` for inline pages without an `id`, causing it to
+    incorrectly fall into the non-paginated branch.  [[#550] by Lee Dogeon]
+
 
 Version 1.10.2
 --------------
@@ -132,6 +141,23 @@ Released on December 24, 2025.
  -  Implemented `list()` method in `WorkersKvStore`.  [[#498], [#500]]
 
 
+Version 1.9.5
+-------------
+
+Released on February 1, 2026.
+
+### @fedify/fedify
+
+ -  Fixed `traverseCollection()` yielding no items when a `Collection` has
+    an inline `CollectionPage` in its `first` property without an explicit
+    `id`.  This is common in Mastodon's `replies` collections.  The function
+    previously used `collection.firstId` to determine pagination, which
+    returned `null` for inline pages without an `id`, causing it to
+    incorrectly fall into the non-paginated branch.  [[#550] by Lee Dogeon]
+
+[#550]: https://github.com/fedify-dev/fedify/pull/550
+
+
 Version 1.9.4
 -------------
 

packages/fedify/src/testing/fixtures/example.com/inline-paged-collection.json

@@ -0,0 +1,13 @@
+{
+  "@context": "https://www.w3.org/ns/activitystreams",
+  "id": "https://example.com/inline-paged-collection",
+  "type": "Collection",
+  "first": {
+    "type": "CollectionPage",
+    "partOf": "https://example.com/inline-paged-collection",
+    "next": "https://example.com/inline-paged/a",
+    "items": [
+      { "type": "Note", "content": "Inline first note" }
+    ]
+  }
+}

packages/fedify/src/testing/fixtures/example.com/inline-paged/a.json

@@ -0,0 +1,8 @@
+{
+  "@context": "https://www.w3.org/ns/activitystreams",
+  "type": "CollectionPage",
+  "partOf": "https://example.com/inline-paged-collection",
+  "items": [
+    { "type": "Note", "content": "Inline second note" }
+  ]
+}

packages/fedify/src/vocab/lookup.test.ts

@@ -5,6 +5,7 @@ import {
   assertRejects,
 } from "@std/assert";
 import fetchMock from "fetch-mock";
+import { deepStrictEqual } from "node:assert";
 import { mockDocumentLoader } from "../testing/docloader.ts";
 import { test } from "../testing/mod.ts";
 import { createTestTracerProvider } from "../testing/otel.ts";
@@ -266,6 +267,21 @@ test("traverseCollection()", {
       new Note({ content: "This is a third simple note" }),
     ],
   );
+  // Inline-paged collection (CollectionPage embedded without id, with next)
+  const inlinePagedCollection = await lookupObject(
+    "https://example.com/inline-paged-collection",
+    options,
+  );
+  assertInstanceOf(inlinePagedCollection, Collection);
+  deepStrictEqual(
+    await Array.fromAsync(
+      traverseCollection(inlinePagedCollection, options),
+    ),
+    [
+      new Note({ content: "Inline first note" }),
+      new Note({ content: "Inline second note" }),
+    ],
+  );
 });
 
 test("FEP-fe34: lookupObject() cross-origin security", {

packages/fedify/src/vocab/lookup.ts

@@ -299,14 +299,14 @@ export async function* traverseCollection(
   collection: Collection,
   options: TraverseCollectionOptions = {},
 ): AsyncIterable<Object | Link> {
-  if (collection.firstId == null) {
+  const interval = Temporal.Duration.from(options.interval ?? { seconds: 0 })
+    .total("millisecond");
+  let page = await collection.getFirst(options);
+  if (page == null) {
     for await (const item of collection.getItems(options)) {
       yield item;
     }
   } else {
-    const interval = Temporal.Duration.from(options.interval ?? { seconds: 0 })
-      .total("millisecond");
-    let page = await collection.getFirst(options);
     while (page != null) {
       for await (const item of page.getItems(options)) {
         yield item;