Skip to content

autopush disable for negative karma fires repeatedly #5944

@AdamWill

Description

@AdamWill

I noticed an interesting pattern on this update. I initially filed negative karma because it failed tests. That caused autopush to be disabled (which is correct). Then the dep issue was cleared up, so I re-enabled autopush. I left my negative karma, though, because AFAIK there is no way to reset to neutral karma, and I couldn't leave positive karma as I had not independently tested the update.

Then somebody else left positive karma...and bodhi disabled autopush again, apparently because of my initial negative karma.

We probably shouldn't re-disable autopush for the same piece of negative karma if it's already been disabled and re-enabled once.

Since we do this with a message trigger (IIRC), perhaps we should only consider the karma that triggered the re-evaluation, not all karma on the update?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions