Skip to content

bodhi updates download: Exit code >0 if something failed #6033

@LecrisUT

Description

@LecrisUT

The most direct case I can see is in

ret = subprocess.call(args)
if ret:
click.echo(f"WARNING: download of {build['nvr']} failed!", err=True)

This should exit non-zero when it failed. Caught this issue in rmdepcheck on Fedora CI, but there the failure is even more tricky, and I do not know where to trace back the cause there, so I would like someone else to look into properly implementing this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions