Skip to content

Commit d8f29e8

Browse files
committed
fix: use double quotes in bash script
1 parent a919df2 commit d8f29e8

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

install-shared.bash

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,16 @@ download_release_tarball() {
1313

1414
__release_response=$(curl \
1515
--retry 3 \
16-
--location $__release_tag_url)
16+
--location "${__release_tag_url}")
1717

18-
__release_url=$(echo $__release_response | jq -r ".assets[] | select(.name | contains(\"${__release_name}\")) | .url")
18+
__release_url=$(echo "${__release_response}" | jq -r ".assets[] | select(.name | contains(\"${__release_name}\")) | .url")
1919

20-
if [[ -z "$__release_url" ]]; then
20+
if [[ -z "${__release_url}" ]]; then
2121
(>&2 echo "failed to download release (tag URL: ${__release_tag_url}, response: ${__release_response})")
2222
return 1
2323
fi
2424

25-
__tar_path="/tmp/${__release_name}_$(basename ${__release_url}).tar.gz"
25+
__tar_path="/tmp/${__release_name}_$(basename "${__release_url}").tar.gz"
2626

2727
__asset_url=$(curl \
2828
--head \
@@ -31,15 +31,15 @@ download_release_tarball() {
3131
--location \
3232
--output /dev/null \
3333
-w %{url_effective} \
34-
"$__release_url")
34+
"{$__release_url}")
3535

36-
curl --retry 3 --output "${__tar_path}" "$__asset_url"
36+
curl --retry 3 --output "${__tar_path}" "${__asset_url}"
3737
if [[ $? -ne "0" ]]; then
3838
(>&2 echo "failed to download release asset (tag URL: ${__release_tag_url}, asset URL: ${__asset_url})")
3939
return 1
4040
fi
4141

42-
eval $__resultvar="'$__tar_path'"
42+
eval $__resultvar="'${__tar_path}'"
4343
}
4444

4545
build_from_source() {
@@ -62,12 +62,12 @@ build_from_source() {
6262
exit 1
6363
fi
6464

65-
pushd $__rust_sources_path
65+
pushd "${__rust_sources_path}"
6666

6767
cargo --version
6868

6969
if [[ -f "./scripts/build-release.sh" ]]; then
70-
./scripts/build-release.sh $__library_name $(cat rust-toolchain)
70+
./scripts/build-release.sh "${__library_name}" "$(cat rust-toolchain)"
7171
else
7272
cargo build --release --all
7373
fi

0 commit comments

Comments
 (0)