Skip to content

Conversation

@snadrus
Copy link
Contributor

@snadrus snadrus commented Nov 10, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 10, 2025 21:31
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Nov 10, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR downgrades the fvm4 dependency from version 4.7.4 to 4.7.3, removes the "nv28-dev" feature flag, and configures GCC 12 across CI jobs to address compilation compatibility issues.

  • Downgrades fvm4 and fvm4_shared from version 4.7.4 to 4.7.3
  • Removes the "nv28-dev" feature from fvm4 dependency
  • Adds GCC 12 installation and environment configuration to all three CI jobs (check, cgo-bindings, supraseal)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
rust/Cargo.toml Downgrades fvm4 packages to version 4.7.3 and removes nv28-dev feature flag
.github/workflows/ci.yml Installs GCC 12 and configures compiler environment variables across CI jobs
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:161

  • The NVCC_PREPEND_FLAGS in the supraseal job is missing the -allow-unsupported-compiler flag that is present in the check job (line 53) and cgo-bindings job (line 118). This inconsistency could lead to different compilation behavior. Consider adding -allow-unsupported-compiler to maintain consistency: NVCC_PREPEND_FLAGS: \"-ccbin /usr/bin/g++-12 -allow-unsupported-compiler\"
      NVCC_PREPEND_FLAGS: "-ccbin /usr/bin/g++-12"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📌 Triage

Development

Successfully merging this pull request may close these issues.

1 participant