Skip to content

Conversation

@tabathad
Copy link
Contributor

@tabathad tabathad commented Dec 1, 2025

The demo video on the homepage was not playing. Users would click
"Watch the demo" and see a black screen with video controls but no
playback.

ReactPlayer's pip={true} prop attempted to enable
Picture-in-Picture before video metadata loaded, causing an error that
prevented playback. This may be related to recent React 19 update, as
the video previously worked with the same ReactPlayer configuration.

Replaced ReactPlayer with native HTML5 <video> element.
The video now plays correctly with all expected functionality:

  • Starts at 8:16 timestamp (using Media Fragments #t=496)
  • Shows browser native controls
  • Works on desktop and mobile
  • Maintains 16:9 aspect ratio in terminal window display

Removed react-player import as it's no longer needed for simple MP4 playback.

fixes #1191

@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
🔨 Latest commit c461e1d
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/692dd84ffe3a2e43093a6df6
😎 Deploy Preview https://deploy-preview-1298.git-proxy.preview.finos.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the fix label Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.35%. Comparing base (9f24d3f) to head (c461e1d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1298   +/-   ##
=======================================
  Coverage   83.35%   83.35%           
=======================================
  Files          70       70           
  Lines        3004     3004           
  Branches      499      499           
=======================================
  Hits         2504     2504           
  Misses        397      397           
  Partials      103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kriswest kriswest requested a review from a team December 1, 2025 17:34
@kriswest
Copy link
Contributor

kriswest commented Dec 1, 2025

@06kellyjac of @grovesy @coopernetes could one of you approve this, I can't see the preview currently (getting FINOS to fix preview generation so that I can in future).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Demo video on website is not playable.

2 participants