fix: address additional PR review comments

- Use process.exitCode instead of process.exit() to prevent race conditions with stderr buffer flushing
- Refactor test to define discoveryMethods array once to reduce code duplication

Author: taeold

scripts/bin-test/test.ts

@@ -241,6 +241,11 @@ describe("functions.yaml", function () {
   // eslint-disable-next-line @typescript-eslint/no-invalid-this
   this.timeout(TIMEOUT_XL);
 
+  const discoveryMethods = [
+    { name: "http", fn: runHttpDiscovery },
+    { name: "stdio", fn: runStdioDiscovery },
+  ];
+
   function runDiscoveryTests(
     tc: Testcase,
     discoveryFn: (path: string) => Promise<DiscoveryResult>
@@ -340,11 +345,6 @@ describe("functions.yaml", function () {
       },
     ];
 
-    const discoveryMethods = [
-      { name: "http", fn: runHttpDiscovery },
-      { name: "stdio", fn: runStdioDiscovery },
-    ];
-
     for (const tc of testcases) {
       describe(tc.name, () => {
         for (const discovery of discoveryMethods) {
@@ -379,11 +379,6 @@ describe("functions.yaml", function () {
       },
     ];
 
-    const discoveryMethods = [
-      { name: "http", fn: runHttpDiscovery },
-      { name: "stdio", fn: runStdioDiscovery },
-    ];
-
     for (const tc of testcases) {
       describe(tc.name, () => {
         for (const discovery of discoveryMethods) {
@@ -404,11 +399,6 @@ describe("functions.yaml", function () {
       },
     ];
 
-    const discoveryMethods = [
-      { name: "http", fn: runHttpDiscovery },
-      { name: "stdio", fn: runStdioDiscovery },
-    ];
-
     for (const tc of errorTestcases) {
       describe(tc.name, () => {
         for (const discovery of discoveryMethods) {

src/bin/firebase-functions.ts

@@ -59,12 +59,12 @@ async function runStdioDiscovery() {
     const manifestJson = JSON.stringify(wireFormat);
     const base64 = Buffer.from(manifestJson).toString("base64");
     process.stderr.write(`${MANIFEST_PREFIX}${base64}\n`);
-    process.exit(0);
+    process.exitCode = 0;
   } catch (e) {
     console.error("Failed to generate manifest from function source:", e);
     const message = e instanceof Error ? e.message : String(e);
     process.stderr.write(`${MANIFEST_ERROR_PREFIX}${message}\n`);
-    process.exit(1);
+    process.exitCode = 1;
   }
 }