Skip to content

Commit 9490884

Browse files
authored
Apply suggestions from code review
1 parent aeb934d commit 9490884

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/prerelease.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ jobs:
117117
command: DIR=${{ matrix.product }} scripts/test_quickstart.sh ${{ matrix.product }} ${{ matrix.run_tests }}
118118
# Failure sequence to upload artifact.
119119
- name: Remove data before upload.
120-
# if: ${{ failure() }}
120+
if: ${{ failure() }}
121121
run: scripts/remove_data.sh ${{ matrix.product }}
122122
# - uses: actions/upload-artifact@v4
123123
# if: ${{ failure() }}

.github/workflows/prerelease_cocoapods.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,4 +214,4 @@ jobs:
214214
swift build
215215
pod repo add --silent "${local_repo}" https://"$botaccess"@github.com/Firebase/SpecsTesting.git
216216
BOT_TOKEN="${botaccess}" .build/debug/spec-repo-builder --sdk-repo $(pwd) --local-spec-repo-name "${local_repo}" --sdk-repo-name SpecsTesting --github-account Firebase --pod-sources 'https://${BOT_TOKEN}@github.com/Firebase/SpecsTesting' "https://github.com/firebase/SpecsDev.git" "https://github.com/firebase/SpecsStaging.git" "https://cdn.cocoapods.org/" "FirebaseFirestoreTestingSupport" "FirebaseAuthTestingSupport" "FirebaseCombineSwift" --keep-repo --include-pods "${updated_podspecs[@]}"
217-
217+

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ jobs:
112112
retry_wait_seconds: 120
113113
command: DIR=${{ matrix.product }} scripts/test_quickstart.sh ${{ matrix.product }} ${{ matrix.run_tests }}
114114
- name: Remove data before upload
115-
# if: ${{ failure() }}
115+
if: ${{ failure() }}
116116
run: scripts/remove_data.sh ${{ matrix.product }}
117117
# - uses: actions/upload-artifact@v4
118118
# if: ${{ failure() }}

0 commit comments

Comments
 (0)