Skip to content

Commit f7a8628

Browse files
authored
fix(ci): Resolve syntax error in zip.yml (#15425)
1 parent 5349b87 commit f7a8628

File tree

4 files changed

+8
-18
lines changed

4 files changed

+8
-18
lines changed

.github/workflows/inappmessaging.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,5 +79,6 @@ jobs:
7979
setup_command: scripts/setup_quickstart_spm.sh inappmessaging
8080
plist_src_path: scripts/gha-encrypted/qs-inappmessaging.plist.gpg
8181
plist_dst_path: quickstart-ios/inappmessaging/GoogleService-Info.plist
82+
run_tests: false
8283
secrets:
8384
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}

.github/workflows/release.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ on:
1515

1616
env:
1717
FIREBASE_CI: true
18+
FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT: true
1819

1920
concurrency:
2021
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
@@ -72,7 +73,7 @@ jobs:
7273
- product: Messaging
7374
run_tests: false
7475
- product: InAppMessaging
75-
run_tests: true
76+
run_tests: false
7677
- product: Firestore
7778
run_tests: false
7879
- product: Database
@@ -82,7 +83,7 @@ jobs:
8283
- product: Crashlytics
8384
run_tests: true
8485
- product: ABTesting
85-
run_tests: true
86+
run_tests: false
8687
name: 'quickstart (release, ${{ matrix.product }}, run_tests: ${{ matrix.run_tests }})'
8788
env:
8889
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}

.github/workflows/zip.yml

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99
# zip from the current commit (HEAD).
1010
name: zip
1111

12-
# TODO(ncooke3): Add FirebaseAI test.
13-
1412
permissions:
1513
actions: read
1614
contents: read
@@ -247,13 +245,6 @@ jobs:
247245
quickstart-ios/abtesting/GoogleService-Info.plist "$plist_secret"
248246
- name: Test Quickstart
249247
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}")
250-
- name: Remove data before upload
251-
if: always()
252-
run: scripts/remove_data.sh abtesting
253-
# - uses: actions/upload-artifact@v4
254-
# if: failure()
255-
# with:
256-
# name: quickstart_artifacts_abtesting
257248
- uses: actions/upload-artifact@v4
258249
if: failure()
259250
with:
@@ -271,7 +262,7 @@ jobs:
271262
strategy:
272263
matrix:
273264
os: [macos-15]
274-
artifact: [Firebase-actions-dir] , Firebase-actions-dir-dynamic]
265+
artifact: [Firebase-actions-dir, Firebase-actions-dir-dynamic]
275266
include:
276267
- os: macos-15
277268
xcode: Xcode_16.4
@@ -462,7 +453,7 @@ jobs:
462453
find "${GITHUB_WORKSPACE}" -name "Firebase*latest.zip" -exec unzip -d "${HOME}"/ios_frameworks/ {} +
463454
- uses: actions/checkout@v4
464455
- name: Setup quickstart
465-
run: SAMPLE="$SDK" TARGET="${SDK}Example" NON_FIREBASE_SDKS="FirebaseDatabaseUI" scripts/setup_quickstart_framework.sh \
456+
run: SAMPLE="$SDK" TARGET="${SDK}ExampleSwift" NON_FIREBASE_SDKS="FirebaseDatabaseUI" scripts/setup_quickstart_framework.sh \
466457
"${HOME}"/ios_frameworks/Firebase/FirebaseDatabase/* \
467458
"${HOME}"/ios_frameworks/Firebase/FirebaseStorage/* \
468459
"${HOME}"/ios_frameworks/Firebase/FirebaseFirestore/* \
@@ -473,7 +464,7 @@ jobs:
473464
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-database.plist.gpg \
474465
quickstart-ios/database/GoogleService-Info.plist "$plist_secret"
475466
- name: Test Quickstart
476-
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}")
467+
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift)
477468
- uses: actions/upload-artifact@v4
478469
if: failure()
479470
with:
@@ -579,8 +570,6 @@ jobs:
579570
- name: Install Secret GoogleService-Info.plist
580571
run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-inappmessaging.plist.gpg \
581572
quickstart-ios/inappmessaging/GoogleService-Info.plist "$plist_secret"
582-
- name: Test Quickstart
583-
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}")
584573
- name: Test Swift Quickstart
585574
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift)
586575
- uses: actions/upload-artifact@v4
@@ -633,8 +622,6 @@ jobs:
633622
quickstart-ios/messaging/GoogleService-Info.plist "$plist_secret"
634623
- name: Test Quickstart
635624
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}")
636-
- name: Test Swift Quickstart
637-
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_framework.sh "${SDK}" swift)
638625
- uses: actions/upload-artifact@v4
639626
if: failure()
640627
with:

Gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# To update, change version below, run bundle install, test,
2+
#
23
# commit Gemfile and Gemfile.lock.
34
source 'https://rubygems.org'
45

0 commit comments

Comments
 (0)