Skip to content

Commit 432d686

Browse files
committed
adds todos and changelog
1 parent 99ece3c commit 432d686

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Adds listServices and also defines trigger within runv2.ts [#9482]

src/gcp/runv2.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -530,11 +530,13 @@ export function endpointFromService(service: Omit<Service, ServiceOutputFields>)
530530
service.annotations?.[FUNCTION_TARGET_ANNOTATION] ||
531531
service.annotations?.[FUNCTION_ID_ANNOTATION] ||
532532
id,
533+
// TODO: Figure out how to encode all trigger types to the underlying Run service that is compatible with both V2 functions and "direct to run" functions
533534
...(service.annotations?.[TRIGGER_TYPE_ANNOTATION] === "HTTP_TRIGGER"
534535
? { httpsTrigger: {} }
535536
: {
536537
eventTrigger: {
537538
eventType: service.annotations?.[TRIGGER_TYPE_ANNOTATION] || "unknown",
539+
// TODO: Figure out how to recover the retry info from Run (vs Functions API) as we currently default to false.
538540
retry: false,
539541
},
540542
}),

0 commit comments

Comments
 (0)