Skip to content

Commit 6ce821e

Browse files
committed
Merge branch 'inlined.crf-deploy' into inlined.run-functions-exp
2 parents 2ae9410 + 0cb1545 commit 6ce821e

File tree

215 files changed

+13573
-1529
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

215 files changed

+13573
-1529
lines changed

.github/ISSUE_TEMPLATE/mcp.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ template_path=.github/ISSUE_TEMPLATE/mcp.md
2323

2424
### Steps to Reproduce
2525

26-
<!-- write a detailed description of how to reproduce>
26+
<!-- write a detailed description of how to reproduce -->

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,3 +27,4 @@ scripts/*.json
2727
lib/
2828
dev/
2929
clean/
30+
.gemini/

.prettierignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
/scripts/webframeworks-deploy-tests/angular/**
77
/scripts/webframeworks-deploy-tests/nextjs/**
88
/src/frameworks/docs/**
9+
/prompts
910

1011
# Intentionally invalid YAML file:
1112
/src/test/fixtures/extension-yamls/invalid/extension.yaml

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
- Updated the Data Connect emulator to use pglite 0.3.x and Postgres 17, which fixes some crashes related to wire protocol inconsistencies. (#8679, #8658)
2-
- Fixed an issue where the IAM enablement for GenKit monitoring would try to change an invalid service account. (#8756)
1+
- Fixed ext:export command so that it correctly returns system params in the .env file (#8881)
2+
- Fixed an issue where the MCP server could not successfully use Application Default Credentials. (#8896)

GEMINI.md

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
# GEMINI.md
2+
3+
This file provides guidance to Gemini CLI or other coding agents when working with code in this repository. It focuses on key conventions and best practices. For a comprehensive guide on the development setup and contribution process, see [`CONTRIBUTING.md`](CONTRIBUTING.md).
4+
5+
## Essential Commands
6+
7+
```bash
8+
# Build the project
9+
npm run build
10+
11+
# Link the package - once this is run, you can manually test changes in your terminal
12+
npm link
13+
14+
npm test # Full test suite with linting and compilation
15+
npm run mocha:fast # Quick unit tests only
16+
npx mocha {testfile} # Quick unit test for a specific file
17+
18+
# Linting and formatting
19+
npm run lint # Check all code
20+
npm run lint:changed-files # Lint changed files only (much faster)
21+
npm run format # Auto-fix formatting issues
22+
```
23+
24+
## Best Practices
25+
26+
### Code Quality & Utilities
27+
28+
- **Look for existing utilities first:** Before writing common helper functions (e.g., for logging, file system operations, promises, string manipulation), check `src/utils.ts` to see if a suitable function already exists.
29+
- **Use the central `logger`** (`src/logger.ts`); never use `console.log()` for user-facing output.
30+
- **Throw `FirebaseError`** (`src/error.ts`) for expected, user-facing errors.
31+
- **API calls must use `apiv2.ts`** for authenticated requests.
32+
33+
### TypeScript
34+
35+
- **Never use `any` or `unknown` as an escape hatch.** Define proper interfaces/types or use type guards.
36+
- Use strict null checks and handle `undefined`/`null` explicitly.
37+
38+
### Testing
39+
40+
- **Avoid excessive mocking in unit tests.** If a test requires many mocks, it might be better as an integration test in `/scripts/[feature]-tests/`.
41+
- **Unit tests (`*.spec.ts`) should be co-located with their source files.**
42+
- Test error cases and edge conditions, not just the "happy path."
43+
44+
## Git Workflow & Pull Requests
45+
46+
1. **Lint and Test Before Committing:** Run `npm run lint:changed-files` for a quick check, and run the full `npm test` before submitting your PR to catch any issues.
47+
2. **Structure Commit Messages for Pull Requests:** To streamline PR creation, format your commit messages to serve as both the commit and the PR description:
48+
- **Subject Line:** A concise, imperative summary (e.g., `feat: add frobnicator support`). This will become the PR title.
49+
- **Body:** After a blank line, structure the commit body to match the PR template. This will pre-populate the PR description. Include:
50+
- `### Description`
51+
- `### Scenarios Tested`
52+
- `### Sample Commands`
53+
- Reference issues with "Fixes #123" in the description.
54+
3. **Update Changelog:** For any user-facing change (new features, bug fixes, deprecations), add a corresponding entry to `CHANGELOG.md`.

firebase-vscode/CHANGELOG.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,23 @@
11
## NEXT
22

3+
## 1.6.0
4+
5+
- Update internal `firebase-tools` dependency to 14.11.1
6+
- [Changed] Now integrates with GCA in its agentic mode, powered by the Gemini CLI. This brings the Firebase MCP Server directly into the VS Code environment, enabling developers to use natural language to generate application schemas and queries without manually invoking explicit tools.
7+
8+
## 1.5.1
9+
10+
- Update internal `firebase-tools` dependency to 14.11.0
11+
- [Fixed] Language server now properly recognizes nested Dataconnect folders
12+
- [Fixed] Add Data and Read Data now properly support enum and list types
13+
14+
## 1.5.0
15+
16+
- Update internal `firebase-tools` dependency to 14.9.0
17+
- Update internal `graphql-language-server` dependency
18+
- Update internal `graphql-language-service-server` dependency
319
- [Changed] Graphql Syntax Highlighter is now an extension dependency
20+
- [Fixed] Language server now recognizes fragments in other files
421

522
## 1.4.1
623

firebase-vscode/common/messaging/protocol.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,10 @@ export interface WebviewToExtensionParamsMap {
123123

124124
// called from execution panel
125125
rerunExecution: void;
126+
127+
/** Docs clicked for analytics */
128+
"docs.mcp.clicked": void;
129+
"docs.tos.clicked": void;
126130
}
127131

128132
export interface DataConnectResults {
Binary file not shown.
Binary file not shown.
Binary file not shown.

0 commit comments

Comments
 (0)