Commit 88d5ef2
Barebones implementation of local builds (#10101)
* Zip deploy fixes
* use staging and specify uploading TAR
* Improve docs
* Allow reading of simple env vars (not secrets) and passing them down to the local build process
* Add some fixes for npm parsing issues
* Adding various local fixes/hacks to make local builds work. It includes:
1. Fix for injecting auto-init variables into the build
2. Fixes how we handle dependencies, nodejs paths, modulepaths, etc. This needs closer attention/fixes.
3. Adds env var handling (not secrets) and determines which env vars to pass down to the build
* Follow-up fixes for ensuring we have account access for cloud storage buckets
* formatting fixes
* Get rid of env override
* Temporarily add a test app to easily test changes
* For local builds, explicitly check for apphosting.yaml files (and all variants) and include them in the final artifact
* Add hono to packages
* Get rid of test app
* Get rid of uniformBucketLevelAccess config which was not required
* Fix tarball unit test
* Make local builds less hardcoded by checking if the build config is actually a local build (instead of assuming true.)
* Add a new experiment flag to control local builds (apphostinglocalbuilds)
* Remove references to runtime flag
* Clean up the PR so that we gate by apphostinglocalbuilds experiment more strictly. We also remove some hardcoded values and we generalize the code so that it does not affect source deploys.
The goal is to prepare this PR so that we can safely submit it to main (behind the experiment flag.)
* Make the code for adding service account IAM permission more restrictive. Only run it if it's a local build and the local build experiment flag is enabled.
* remove es2020 dependency
* feat: barebones local build implementation
* Parser fixes
* Undo some unintended changes
* Undo some unintended changes
* Linter fixes
* Linter fixes
* improve unit tests
* update npm shrinkwrap
* Update the shrinkwrap correctly using the correct npm versions
* Remove env handling which wasn't used yet
* Address review comments
* Enforce experiment flag
* Correct failure string
* linter/formatter
* fix tests
* Fix linter warnings
---------
Co-authored-by: Joanna Wang <annajowang@gmail.com>
Co-authored-by: annajowang <31288696+annajowang@users.noreply.github.com>1 parent e44d873 commit 88d5ef2
12 files changed
Lines changed: 522 additions & 44 deletions
File tree
- src
- apphosting
- deploy/apphosting
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | | - | |
| 107 | + | |
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| |||
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
| 171 | + | |
171 | 172 | | |
172 | 173 | | |
173 | 174 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
6 | 16 | | |
7 | 17 | | |
8 | 18 | | |
| |||
0 commit comments