Fixed an issue where the VSCE extension used the wrong host for execution on Studio (#8849)

* Fixed an issue where the VSCE extension used the wrong host for execution  on Studio

* format

* Fix overwriting issue

Author: joehan

firebase-vscode/src/options.ts

@@ -1,6 +1,5 @@
 import { RC } from "../../src/rc";
 import { Options } from "../../src/options";
-import { Command } from "../../src/command";
 import { ExtensionContext } from "vscode";
 import { setInquirerOptions } from "./stubs/inquirer-stub";
 import { Config } from "../../src/config";

src/emulator/env.ts

@@ -97,7 +97,8 @@ export function maybeUsePortForwarding(i: EmulatorInfo): EmulatorInfo {
     }
     const url = `${info.port}-${portForwardingHost}`;
     info.host = url;
-    info.listen = info.listen?.map((l) => {
+    info.listen = info.listen?.map((listen) => {
+      const l = { ...listen };
       l.address = url;
       l.port = 443;
       return l;

src/emulator/hub.ts

@@ -13,7 +13,6 @@ import { ExpressBasedEmulator } from "./ExpressBasedEmulator";
 import { PortName } from "./portUtils";
 import { DataConnectEmulator } from "./dataconnectEmulator";
 import { isVSCodeExtension } from "../vsCodeUtils";
-import { maybeUsePortForwarding } from "./env";
 
 // We use the CLI version from package.json
 const pkg = require("../../package.json");
@@ -83,10 +82,10 @@ export class EmulatorHub extends ExpressBasedEmulator {
   getRunningEmulatorsMapping(): GetEmulatorsResponse {
     const emulators: GetEmulatorsResponse = {};
     for (const info of EmulatorRegistry.listRunningWithInfo()) {
-      emulators[info.name] = maybeUsePortForwarding({
+      emulators[info.name] = {
         listen: this.args.listenForEmulator[info.name],
         ...info,
-      });
+      };
     }
     return emulators;
   }

src/emulator/ui.ts

@@ -10,6 +10,8 @@ import { AnalyticsSession, emulatorSession } from "../track";
 import { ExpressBasedEmulator } from "./ExpressBasedEmulator";
 import { ALL_EXPERIMENTS, ExperimentName, isEnabled } from "../experiments";
 import { EmulatorHub, GetEmulatorsResponse } from "./hub";
+import { mapObject } from "../functional";
+import { maybeUsePortForwarding } from "./env";
 
 export interface EmulatorUIOptions {
   listen: ListenSpec[];
@@ -60,7 +62,10 @@ export class EmulatorUI extends ExpressBasedEmulator {
     app.get(
       "/api/config",
       this.jsonHandler(() => {
-        const emulatorInfos = (hub! as EmulatorHub).getRunningEmulatorsMapping();
+        const emulatorInfos = mapObject(
+          (hub! as EmulatorHub).getRunningEmulatorsMapping(),
+          maybeUsePortForwarding,
+        );
         const json: EmulatorConfigInfo = {
           projectId,
           experiments: enabledExperiments ?? [],