Skip to content

Commit bd17df5

Browse files
tweaked it a bit
1 parent dcd3229 commit bd17df5

2 files changed

Lines changed: 5 additions & 13 deletions

File tree

src/firebase_studio/migrate.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ describe("migrate", () => {
405405
expect(confirmStub.called).to.be.false;
406406
});
407407

408-
it("should only upgrade genkit-cli version to 1.30 if present in package.json", async () => {
408+
it("should only upgrade genkit-cli version to ^1.28.0 if present in package.json", async () => {
409409
readFileStub.callsFake(async (p: any) => {
410410
const pStr = p.toString();
411411
if (pStr.endsWith("metadata.json"))
@@ -436,7 +436,7 @@ describe("migrate", () => {
436436
const packageJsonCall = writeFileStub.args.find((a) => a[0].endsWith("package.json"));
437437
expect(packageJsonCall).to.not.be.undefined;
438438
const packageJson = JSON.parse(packageJsonCall![1]);
439-
expect(packageJson.devDependencies["genkit-cli"]).to.equal("1.30");
439+
expect(packageJson.devDependencies["genkit-cli"]).to.equal("^1.28.0");
440440
expect(packageJson.dependencies.genkit).to.equal("1.0.0");
441441
expect(packageJson.dependencies["@genkit-ai/googleai"]).to.equal("1.0.0");
442442
expect(packageJson.dependencies.next).to.equal("14.0.0");

src/firebase_studio/migrate.ts

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -613,25 +613,17 @@ async function upgradeGenkitVersion(rootPath: string): Promise<void> {
613613
};
614614
let modified = false;
615615

616-
if (
617-
packageJson.dependencies?.["genkit-cli"] &&
618-
packageJson.dependencies["genkit-cli"] !== "1.30"
619-
) {
620-
packageJson.dependencies["genkit-cli"] = "1.30";
621-
modified = true;
622-
}
623-
624616
if (
625617
packageJson.devDependencies?.["genkit-cli"] &&
626-
packageJson.devDependencies["genkit-cli"] !== "1.30"
618+
packageJson.devDependencies["genkit-cli"] !== "^1.28.0"
627619
) {
628-
packageJson.devDependencies["genkit-cli"] = "1.30";
620+
packageJson.devDependencies["genkit-cli"] = "^1.28.0";
629621
modified = true;
630622
}
631623

632624
if (modified) {
633625
await fs.writeFile(packageJsonPath, JSON.stringify(packageJson, null, 2) + "\n");
634-
logger.info("✅ Upgraded genkit-cli version to 1.30 in package.json");
626+
logger.info("✅ Upgraded genkit-cli version to 1.28 in package.json");
635627
}
636628
} catch (err: unknown) {
637629
const message = err instanceof Error ? err.message : String(err);

0 commit comments

Comments
 (0)