chore(analytics): Remove cSettings from Package.swift (#17567)

koji-1009 · web-flow · commit e7af1b0fc20d · 2025-07-30T09:12:51.000Z
diff --git a/packages/firebase_analytics/firebase_analytics/ios/firebase_analytics/Package.swift b/packages/firebase_analytics/firebase_analytics/ios/firebase_analytics/Package.swift
@@ -61,13 +61,11 @@ func loadPubspecVersions() throws -> (packageVersion: String, firebaseCoreVersio
   }
 }
 
-let library_version: String
 let firebase_sdk_version_string: String
 let firebase_core_version_string: String
 let shared_spm_tag = "-firebase-core-swift"
 
 do {
-  library_version = try loadPubspecVersions().packageVersion
   firebase_sdk_version_string = try loadFirebaseSDKVersion()
   firebase_core_version_string = try loadPubspecVersions().firebaseCoreVersion
 } catch {
@@ -104,11 +102,6 @@ let package = Package(
       ],
       resources: [
         .process("Resources"),
-      ],
-      cSettings: [
-        .headerSearchPath("include"),
-        .define("LIBRARY_VERSION", to: "\"\(library_version)\""),
-        .define("LIBRARY_NAME", to: "\"flutter-fire-analytics\""),
       ]
     ),
   ]
diff --git a/packages/firebase_analytics/firebase_analytics/macos/firebase_analytics/Package.swift b/packages/firebase_analytics/firebase_analytics/macos/firebase_analytics/Package.swift
@@ -63,13 +63,11 @@ func loadPubspecVersions() throws -> (packageVersion: String, firebaseCoreVersio
   }
 }
 
-let library_version: String
 let firebase_sdk_version_string: String
 let firebase_core_version_string: String
 let shared_spm_tag = "-firebase-core-swift"
 
 do {
-  library_version = try loadPubspecVersions().packageVersion
   firebase_sdk_version_string = try loadFirebaseSDKVersion()
   firebase_core_version_string = try loadPubspecVersions().firebaseCoreVersion
 } catch {
@@ -106,11 +104,6 @@ let package = Package(
       ],
       resources: [
         .process("Resources"),
-      ],
-      cSettings: [
-        .headerSearchPath("include"),
-        .define("LIBRARY_VERSION", to: "\"\(library_version)\""),
-        .define("LIBRARY_NAME", to: "\"flutter-fire-analytics\""),
       ]
     ),
   ]

Original file line number	Diff line number	Diff line change
`@@ -61,13 +61,11 @@ func loadPubspecVersions() throws -> (packageVersion: String, firebaseCoreVersio`
`61`	`61`	`}`
`62`	`62`	`}`
`63`	`63`
`64`		`-let library_version: String`
`65`	`64`	`let firebase_sdk_version_string: String`
`66`	`65`	`let firebase_core_version_string: String`
`67`	`66`	`let shared_spm_tag = "-firebase-core-swift"`
`68`	`67`
`69`	`68`	`do {`
`70`		`- library_version = try loadPubspecVersions().packageVersion`
`71`	`69`	`firebase_sdk_version_string = try loadFirebaseSDKVersion()`
`72`	`70`	`firebase_core_version_string = try loadPubspecVersions().firebaseCoreVersion`
`73`	`71`	`} catch {`
`@@ -104,11 +102,6 @@ let package = Package(`
`104`	`102`	`],`
`105`	`103`	`resources: [`
`106`	`104`	`.process("Resources"),`
`107`		`- ],`
`108`		`- cSettings: [`
`109`		`- .headerSearchPath("include"),`
`110`		`- .define("LIBRARY_VERSION", to: "\"\(library_version)\""),`
`111`		`- .define("LIBRARY_NAME", to: "\"flutter-fire-analytics\""),`
`112`	`105`	`]`
`113`	`106`	`),`
`114`	`107`	`]`
Original file line number	Diff line number	Diff line change
`@@ -63,13 +63,11 @@ func loadPubspecVersions() throws -> (packageVersion: String, firebaseCoreVersio`
`63`	`63`	`}`
`64`	`64`	`}`
`65`	`65`
`66`		`-let library_version: String`
`67`	`66`	`let firebase_sdk_version_string: String`
`68`	`67`	`let firebase_core_version_string: String`
`69`	`68`	`let shared_spm_tag = "-firebase-core-swift"`
`70`	`69`
`71`	`70`	`do {`
`72`		`- library_version = try loadPubspecVersions().packageVersion`
`73`	`71`	`firebase_sdk_version_string = try loadFirebaseSDKVersion()`
`74`	`72`	`firebase_core_version_string = try loadPubspecVersions().firebaseCoreVersion`
`75`	`73`	`} catch {`
`@@ -106,11 +104,6 @@ let package = Package(`
`106`	`104`	`],`
`107`	`105`	`resources: [`
`108`	`106`	`.process("Resources"),`
`109`		`- ],`
`110`		`- cSettings: [`
`111`		`- .headerSearchPath("include"),`
`112`		`- .define("LIBRARY_VERSION", to: "\"\(library_version)\""),`
`113`		`- .define("LIBRARY_NAME", to: "\"flutter-fire-analytics\""),`
`114`	`107`	`]`
`115`	`108`	`),`
`116`	`109`	`]`