Skip to content

Commit ab9c2b9

Browse files
committed
fix: apply improvements to cli workflows
1 parent cca6438 commit ab9c2b9

File tree

2 files changed

+26
-38
lines changed

2 files changed

+26
-38
lines changed

.github/workflows/build-cli-binaries.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -321,11 +321,11 @@ jobs:
321321
322322
## Downloads (Unsigned - For Testing Only)
323323
324-
- [Linux x64](https://github.com/firebase/genkit/releases/download/${{ inputs.version }}/genkit-linux-x64)
325-
- [Linux ARM64](https://github.com/firebase/genkit/releases/download/${{ inputs.version }}/genkit-linux-arm64)
326-
- [macOS x64](https://github.com/firebase/genkit/releases/download/${{ inputs.version }}/genkit-darwin-x64)
327-
- [macOS ARM64](https://github.com/firebase/genkit/releases/download/${{ inputs.version }}/genkit-darwin-arm64)
328-
- [Windows x64](https://github.com/firebase/genkit/releases/download/${{ inputs.version }}/genkit-win32-x64.exe)
324+
- [Linux x64](https://github.com/${{ github.repository }}/releases/download/${{ inputs.version }}/genkit-linux-x64)
325+
- [Linux ARM64](https://github.com/${{ github.repository }}/releases/download/${{ inputs.version }}/genkit-linux-arm64)
326+
- [macOS x64](https://github.com/${{ github.repository }}/releases/download/${{ inputs.version }}/genkit-darwin-x64)
327+
- [macOS ARM64](https://github.com/${{ github.repository }}/releases/download/${{ inputs.version }}/genkit-darwin-arm64)
328+
- [Windows x64](https://github.com/${{ github.repository }}/releases/download/${{ inputs.version }}/genkit-win32-x64.exe)
329329
330330
## Changes
331331
@@ -339,7 +339,7 @@ jobs:
339339
340340
```bash
341341
# Download and test the RC binary
342-
curl -Lo genkit https://github.com/firebase/genkit/releases/download/${{ inputs.version }}/genkit-$(uname -s | tr '[:upper:]' '[:lower:]')-$(uname -m | sed 's/x86_64/x64/;s/aarch64/arm64/')
342+
curl -Lo genkit https://github.com/${{ github.repository }}/releases/download/${{ inputs.version }}/genkit-$(uname -s | tr '[:upper:]' '[:lower:]')-$(uname -m | sed 's/x86_64/x64/;s/aarch64/arm64/')
343343
chmod +x genkit
344344
./genkit --version
345345
```

.github/workflows/promote-cli-release.yml

Lines changed: 20 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ on:
2828
required: true
2929
type: string
3030

31+
permissions:
32+
contents: write
33+
3134
jobs:
3235
validate-and-promote:
3336
runs-on: ubuntu-latest
@@ -206,12 +209,10 @@ jobs:
206209
207210
- name: Create final release
208211
id: create_release
209-
uses: actions/create-release@v1
210-
env:
211-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
212+
uses: softprops/action-gh-release@v2
212213
with:
213214
tag_name: ${{ inputs.final_version }}
214-
release_name: Genkit CLI ${{ inputs.final_version }}
215+
name: Genkit CLI ${{ inputs.final_version }}
215216
body: |
216217
# Genkit CLI ${{ inputs.final_version }}
217218
@@ -231,15 +232,15 @@ jobs:
231232
232233
### Quick Install (Recommended)
233234
234-
```bash
235+
\`\`\`bash
235236
curl -sL https://genkit.tools | bash
236-
```
237+
\`\`\`
237238
238239
### Manual Installation
239240
240-
```bash
241+
\`\`\`bash
241242
# Download the appropriate binary for your platform
242-
curl -Lo genkit https://github.com/${{ github.repository }}/releases/download/${{ inputs.final_version }}/genkit-$(uname -s | tr '[:upper:]' '[:lower:]')-$(uname -m | sed 's/x86_64/x64/;s/aarch64/arm64/')
243+
curl -Lo genkit https://github.com/${{ github.repository }}/releases/download/${{ inputs.final_version }}/genkit-\$(uname -s | tr '[:upper:]' '[:lower:]')-\$(uname -m | sed 's/x86_64/x64/;s/aarch64/arm64/')
243244
244245
# Make it executable
245246
chmod +x genkit
@@ -249,45 +250,32 @@ jobs:
249250
250251
# Verify installation
251252
genkit --version
252-
```
253+
\`\`\`
253254
254255
### Windows Installation
255256
256-
```powershell
257+
\`\`\`powershell
257258
# Download the Windows binary
258259
Invoke-WebRequest -Uri "https://github.com/${{ github.repository }}/releases/download/${{ inputs.final_version }}/genkit-win32-x64.exe" -OutFile "genkit.exe"
259260
260261
# Add to PATH or run from current directory
261262
.\genkit.exe --version
262-
```
263+
\`\`\`
263264
264265
## Documentation
265266
266267
For more information, visit [https://firebase.google.com/docs/genkit/](https://firebase.google.com/docs/genkit/)
267268
draft: false
268269
prerelease: false
270+
files: |
271+
release-assets/genkit-linux-x64
272+
release-assets/genkit-linux-arm64
273+
release-assets/genkit-darwin-x64
274+
release-assets/genkit-darwin-arm64
275+
release-assets/genkit-win32-x64.exe
276+
make_latest: true
269277

270-
- name: Upload release assets
271-
env:
272-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
273-
run: |
274-
UPLOAD_URL="${{ steps.create_release.outputs.upload_url }}"
275-
276-
echo "Uploading binaries to final release..."
277-
278-
for file in release-assets/*; do
279-
filename=$(basename "$file")
280-
echo "Uploading $filename..."
281-
282-
curl -X POST \
283-
-H "Authorization: token $GITHUB_TOKEN" \
284-
-H "Content-Type: application/octet-stream" \
285-
--data-binary "@$file" \
286-
"${UPLOAD_URL}?name=$filename" | jq -r '.browser_download_url'
287-
done
288-
289-
echo ""
290-
echo "✅ All binaries uploaded successfully"
278+
291279

292280
- name: Update latest tag
293281
run: |

0 commit comments

Comments
 (0)