fix: throw error with duplicate action key #3021
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gioboa
changed the title
|
Hey @gioboa - just checking - it looks like this PR only changes the "log level" from warning to error, and does not actually raise any error. Based on the PR title, though, I think you intend to throw an error? |
Yep, you are right. I fixed the code to get the desired behavior. |
|
Thanks for your review @MichaelDoyle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit change the behavior with actions with the same name.
Based on the issue description I changed warnings into errors.
Close #26
Checklist (if applicable):