Skip to content

Commit 31d316f

Browse files
authored
Merge pull request #1231 from SliverHorn/fix
fixed: c.ShouldBindXxx 未处理错误 以及注释错误
2 parents 7b80ea5 + 8f31d6f commit 31d316f

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

server/api/v1/system/sys_api.go

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,18 +121,23 @@ func (s *SystemApiApi) GetApiList(c *gin.Context) {
121121
// @Router /api/getApiById [post]
122122
func (s *SystemApiApi) GetApiById(c *gin.Context) {
123123
var idInfo request.GetById
124-
_ = c.ShouldBindJSON(&idInfo)
125-
if err := utils.Verify(idInfo, utils.IdVerify); err != nil {
124+
err := c.ShouldBindJSON(&idInfo)
125+
if err != nil {
126+
response.FailWithMessage(err.Error(), c)
127+
return
128+
}
129+
err = utils.Verify(idInfo, utils.IdVerify)
130+
if err != nil {
126131
response.FailWithMessage(err.Error(), c)
127132
return
128133
}
129134
api, err := apiService.GetApiById(idInfo.ID)
130135
if err != nil {
131136
global.GVA_LOG.Error("获取失败!", zap.Error(err))
132137
response.FailWithMessage("获取失败", c)
133-
} else {
134-
response.OkWithDetailed(systemRes.SysAPIResponse{Api: api}, "获取成功", c)
138+
return
135139
}
140+
response.OkWithDetailed(systemRes.SysAPIResponse{Api: api}, "获取成功", c)
136141
}
137142

138143
// UpdateApi

server/api/v1/system/sys_menu.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,11 @@ func (a *AuthorityMenuApi) GetBaseMenuTree(c *gin.Context) {
6464
// @Router /menu/addMenuAuthority [post]
6565
func (a *AuthorityMenuApi) AddMenuAuthority(c *gin.Context) {
6666
var authorityMenu systemReq.AddMenuAuthorityInfo
67-
_ = c.ShouldBindJSON(&authorityMenu)
67+
err := c.ShouldBindJSON(&authorityMenu)
68+
if err != nil {
69+
response.FailWithMessage(err.Error(), c)
70+
return
71+
}
6872
if err := utils.Verify(authorityMenu, utils.AuthorityIdVerify); err != nil {
6973
response.FailWithMessage(err.Error(), c)
7074
return

server/api/v1/system/sys_user.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,6 @@ func (b *BaseApi) ChangePassword(c *gin.Context) {
178178
response.OkWithMessage("修改成功", c)
179179
}
180180

181-
// GetUserList
182181
// GetUserList
183182
// @Tags SysUser
184183
// @Summary 分页获取用户列表

0 commit comments

Comments
 (0)