Bug fixes (#455)

* Added null check for val in onSaved and validator

When _savedValue != null Card widget is mounted instead of GestureDetector which causes val to be null in onSaved and validator methods.

* Fix GroupedCheckbox not disabled when read only

* Added phone validation and fixed initialValue parsing

* Fix Image.memory throwing error when _savedValue null

Author: tejisav-fandemand

lib/src/fields/form_builder_checkbox_group.dart

@@ -143,7 +143,9 @@ class _FormBuilderCheckboxGroupState<T>
             focusColor: widget.focusColor,
             checkColor: widget.checkColor,
             materialTapTargetSize: widget.materialTapTargetSize,
-            disabled: widget.disabled,
+            disabled: _readOnly
+                ? widget.options.map((e) => e.value).toList()
+                : widget.disabled,
             hoverColor: widget.hoverColor,
             tristate: widget.tristate,
             wrapAlignment: widget.wrapAlignment,

lib/src/fields/form_builder_phone_field.dart

@@ -129,6 +129,7 @@ class FormBuilderPhoneFieldState extends State<FormBuilderPhoneField> {
   final GlobalKey<FormFieldState> _fieldKey = GlobalKey<FormFieldState>();
   String _initialValue;
   Country _selectedDialogCountry;
+  bool phoneNumberValid = true;
 
   String get fullNumber {
     // When there is no phone number text, the field is empty -- the country
@@ -151,30 +152,37 @@ class FormBuilderPhoneFieldState extends State<FormBuilderPhoneField> {
     _effectiveController = widget.controller ?? TextEditingController();
     _selectedDialogCountry = CountryPickerUtils.getCountryByIsoCode(
         widget.defaultSelectedCountryIsoCode);
-    _parsePhone();
+    _validatePhoneNumber(_initialValue, setVal: true);
   }
 
-  Future<void> _parsePhone() async {
-    if (_initialValue != null && _initialValue.isNotEmpty) {
+  void _validatePhoneNumber(String val, {bool setVal = false}) async {
+    if (val != null && val.isNotEmpty) {
       try {
-        var parseResult = await PhoneNumber().parse(_initialValue);
-        print(parseResult);
-        if (parseResult != null) {
+        final result = await PhoneNumber().parse(val);
+        if (result != null) {
           setState(() {
-            _selectedDialogCountry = CountryPickerUtils.getCountryByPhoneCode(
-                parseResult['country_code']);
+            phoneNumberValid = true;
+            if (setVal) {
+              _selectedDialogCountry = CountryPickerUtils.getCountryByPhoneCode(
+                  result['country_code']);
+              _effectiveController.text = result['national_number'];
+            }
           });
-          _effectiveController.text = parseResult['national_number'];
         }
-      } catch (error) {
-        print(error);
-        _effectiveController.text = _initialValue.replaceFirst('+', '');
+      } on PlatformException catch (_) {
+        setState(() {
+          phoneNumberValid = false;
+        });
       }
-      setState(() {});
+    } else {
+      setState(() {
+        phoneNumberValid = true;
+      });
     }
   }
 
   void _invokeChange(FormFieldState field) {
+    _validatePhoneNumber(fullNumber);
     field.didChange(fullNumber);
     widget.onChanged?.call(fullNumber);
   }
@@ -187,8 +195,14 @@ class FormBuilderPhoneFieldState extends State<FormBuilderPhoneField> {
       key: _fieldKey,
       initialValue: _initialValue,
       autovalidate: widget.autovalidate,
-      validator: (val) =>
-          FormBuilderValidators.validateValidators(val, widget.validators),
+      validator: (val) {
+        if (phoneNumberValid) {
+          return FormBuilderValidators.validateValidators(
+              val, widget.validators);
+        } else {
+          return 'This field requires a valid phone number.';
+        }
+      },
       onSaved: (val) {
         var transformed;
         if (widget.valueTransformer != null) {

lib/src/fields/form_builder_signature_pad.dart

@@ -108,9 +108,12 @@ class _FormBuilderSignaturePadState extends State<FormBuilderSignaturePad> {
       key: _fieldKey,
       enabled: !_readOnly,
       initialValue: _initialValue,
-      validator: (val) =>
-          FormBuilderValidators.validateValidators(val, widget.validators),
+      validator: (val) {
+        if (_savedValue != null && val == null) return;
+        FormBuilderValidators.validateValidators(val, widget.validators);
+      },
       onSaved: (val) {
+        if (_savedValue != null && val == null) return;
         var transformed;
         if (widget.valueTransformer != null) {
           transformed = widget.valueTransformer(val);
@@ -141,7 +144,7 @@ class _FormBuilderSignaturePadState extends State<FormBuilderSignaturePad> {
                         elevation: 0,
                         color: widget.backgroundColor,
                         child: Image.memory(
-                          _savedValue,
+                          _savedValue ?? Uint8List(0),
                           height: widget.height,
                           width: widget.width,
                         ),