Fixed bug in parsing phone number from PhoneField's initialValue

Author: danvick

CHANGELOG.md

@@ -1,3 +1,8 @@
+## [3.12.3] - 05-Aug-2020
+* Fixed bug in parsing phone number from `FormBuilderPhoneField`'s `initialValue`
+* Added more TextField options: `toolbarOptions`, `smartQuotesType`, `smartDashesType`, `scrollPhysics`, `enableSuggestions`
+* Fixed `onChanged` bug on TextField
+
 ## [3.12.2] - 03-Aug-2020
 * Convert FormBuilderRating value to double for RatingBar. Closes #392
 

example/lib/main.dart

@@ -237,7 +237,9 @@ class MyHomePageState extends State<MyHomePage> {
                     label: RichText(
                       text: TextSpan(
                         children: [
-                          TextSpan(text: 'I have read and agree to the ', style: TextStyle(color: Colors.black)),
+                          TextSpan(
+                              text: 'I have read and agree to the ',
+                              style: TextStyle(color: Colors.black)),
                           TextSpan(
                             text: 'Terms and Conditions',
                             style: TextStyle(color: Colors.blue),
@@ -263,8 +265,8 @@ class MyHomePageState extends State<MyHomePage> {
                     controller: _ageController,
                     decoration: InputDecoration(
                       labelText: 'Age',
-                      suffixIcon: _ageHasError ?
-                          Icon(Icons.error, color: Colors.red)
+                      suffixIcon: _ageHasError
+                          ? Icon(Icons.error, color: Colors.red)
                           : Icon(Icons.check, color: Colors.green),
                     ),
                     onChanged: (val) {
@@ -601,5 +603,3 @@ class MyHomePageState extends State<MyHomePage> {
     );
   }
 }
-
-

lib/src/fields/form_builder_phone_field.dart

@@ -153,9 +153,6 @@ class FormBuilderPhoneFieldState extends State<FormBuilderPhoneField> {
     _selectedDialogCountry = CountryPickerUtils.getCountryByIsoCode(
         widget.defaultSelectedCountryIsoCode);
     _parsePhone();
-    _effectiveController.addListener(() {
-      _invokeChange(_fieldKey.currentState);
-    });
     super.initState();
   }
 
@@ -165,8 +162,10 @@ class FormBuilderPhoneFieldState extends State<FormBuilderPhoneField> {
         var parseResult = await PhoneNumber().parse(_initialValue);
         print(parseResult);
         if (parseResult != null) {
-          _selectedDialogCountry = CountryPickerUtils.getCountryByPhoneCode(
-              parseResult['country_code']);
+          setState(() {
+            _selectedDialogCountry = CountryPickerUtils.getCountryByPhoneCode(
+                parseResult['country_code']);
+          });
           _effectiveController.text = parseResult['national_number'];
         }
       } catch (error) {
@@ -176,9 +175,8 @@ class FormBuilderPhoneFieldState extends State<FormBuilderPhoneField> {
   }
 
   void _invokeChange(FormFieldState field) {
-    final newFullNumber = fullNumber;
-    field.didChange(newFullNumber);
-    widget.onChanged?.call(newFullNumber);
+    field.didChange(fullNumber);
+    widget.onChanged?.call(fullNumber);
   }
 
   @override
@@ -214,6 +212,9 @@ class FormBuilderPhoneFieldState extends State<FormBuilderPhoneField> {
             prefix: _textFieldPrefix(field),
           ),
           // initialValue: "${_initialValue ?? ''}",
+          onChanged: (val) {
+            _invokeChange(field);
+          },
           maxLines: widget.maxLines,
           keyboardType: widget.keyboardType,
           obscureText: widget.obscureText,

pubspec.yaml

@@ -1,6 +1,6 @@
 name: flutter_form_builder
 description: Package to build Material Form with fields like TextField, DropDown, Switches etc. with ability to create custom FormFields and composability and reuse validation functions.
-version: 3.12.2
+version: 3.12.3
 homepage: https://github.com/danvick/flutter_form_builder
 
 environment: