Skip to content

Commit 9d42101

Browse files
authored
Merge pull request #8 from tauu/addCandidate-promise
switch to promise version of addIceCandidate to fix running on Firefox / Safari
2 parents 83fc41e + f5318df commit 9d42101

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

lib/src/rtc_peerconnection_impl.dart

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -227,18 +227,9 @@ class RTCPeerConnectionWeb extends RTCPeerConnection {
227227
}
228228

229229
@override
230-
Future<void> addCandidate(RTCIceCandidate candidate) async {
231-
try {
232-
Completer completer = Completer<void>();
233-
var success = js.allowInterop(() => completer.complete());
234-
var failure = js.allowInterop((e) => completer.completeError(e));
235-
jsutil.callMethod(
236-
_jsPc, 'addIceCandidate', [_iceToJs(candidate), success, failure]);
237-
238-
return completer.future;
239-
} catch (e) {
240-
print(e.toString());
241-
}
230+
Future<void> addCandidate(RTCIceCandidate candidate) {
231+
return jsutil.promiseToFuture<void>(
232+
jsutil.callMethod(_jsPc, 'addIceCandidate', [_iceToJs(candidate)]));
242233
}
243234

244235
@override

0 commit comments

Comments
 (0)