Skip to content

Commit 0061d44

Browse files
committed
remove unused func
Signed-off-by: yuteng chen <a08h0283@gmail.com>
1 parent f4429c9 commit 0061d44

2 files changed

Lines changed: 0 additions & 76 deletions

File tree

flyteplugins/go/tasks/plugins/k8s/ray/ray.go

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313
rayv1 "github.com/ray-project/kuberay/ray-operator/apis/ray/v1"
1414
"gopkg.in/yaml.v2"
1515
v1 "k8s.io/api/core/v1"
16-
"k8s.io/apimachinery/pkg/api/resource"
1716
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1817
"k8s.io/client-go/kubernetes/scheme"
1918
"k8s.io/utils/ptr"
@@ -160,25 +159,6 @@ func buildAutoscalerOptions(options *plugins.AutoscalerOptions) *rayv1.Autoscale
160159
return autoScalerOptions
161160
}
162161

163-
func convertResourceEntriesToResourceList(entries []*core.Resources_ResourceEntry) v1.ResourceList {
164-
resourceList := v1.ResourceList{}
165-
for _, entry := range entries {
166-
var name v1.ResourceName
167-
switch entry.GetName() {
168-
case core.Resources_CPU:
169-
name = v1.ResourceCPU
170-
case core.Resources_MEMORY:
171-
name = v1.ResourceMemory
172-
default:
173-
continue
174-
}
175-
if q, err := resource.ParseQuantity(entry.GetValue()); err == nil {
176-
resourceList[name] = q
177-
}
178-
}
179-
return resourceList
180-
}
181-
182162
func constructRayJob(taskCtx pluginsCore.TaskExecutionContext, rayJob *plugins.RayJob, objectMeta *metav1.ObjectMeta, taskPodSpec v1.PodSpec, headNodeRayStartParams map[string]string, primaryContainerIdx int, primaryContainer v1.Container) (*rayv1.RayJob, error) {
183163
cfg := GetConfig()
184164

flyteplugins/go/tasks/plugins/k8s/ray/ray_test.go

Lines changed: 0 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -1593,62 +1593,6 @@ func transformStructToStructPB(t *testing.T, obj interface{}) *structpb.Struct {
15931593
return s
15941594
}
15951595

1596-
func TestConvertResourceEntriesToResourceList(t *testing.T) {
1597-
tests := []struct {
1598-
name string
1599-
entries []*core.Resources_ResourceEntry
1600-
wantKeys []corev1.ResourceName
1601-
wantLen int
1602-
}{
1603-
{
1604-
name: "cpu entry",
1605-
entries: []*core.Resources_ResourceEntry{
1606-
{Name: core.Resources_CPU, Value: "500m"},
1607-
},
1608-
wantKeys: []corev1.ResourceName{corev1.ResourceCPU},
1609-
wantLen: 1,
1610-
},
1611-
{
1612-
name: "memory entry",
1613-
entries: []*core.Resources_ResourceEntry{
1614-
{Name: core.Resources_MEMORY, Value: "1Gi"},
1615-
},
1616-
wantKeys: []corev1.ResourceName{corev1.ResourceMemory},
1617-
wantLen: 1,
1618-
},
1619-
{
1620-
name: "unknown resource skipped",
1621-
entries: []*core.Resources_ResourceEntry{
1622-
{Name: core.Resources_ResourceName(99), Value: "1"},
1623-
},
1624-
wantLen: 0,
1625-
},
1626-
{
1627-
name: "invalid quantity skipped",
1628-
entries: []*core.Resources_ResourceEntry{
1629-
{Name: core.Resources_CPU, Value: "not-a-quantity"},
1630-
},
1631-
wantLen: 0,
1632-
},
1633-
{
1634-
name: "empty input",
1635-
entries: []*core.Resources_ResourceEntry{},
1636-
wantLen: 0,
1637-
},
1638-
}
1639-
for _, tt := range tests {
1640-
t.Run(tt.name, func(t *testing.T) {
1641-
result := convertResourceEntriesToResourceList(tt.entries)
1642-
require.NotNil(t, result)
1643-
assert.Len(t, result, tt.wantLen)
1644-
for _, key := range tt.wantKeys {
1645-
_, ok := result[key]
1646-
assert.True(t, ok, "expected key %s in result", key)
1647-
}
1648-
})
1649-
}
1650-
}
1651-
16521596
func TestBuildAutoscalerOptions(t *testing.T) {
16531597
t.Run("nil input returns nil", func(t *testing.T) {
16541598
assert.Nil(t, buildAutoscalerOptions(nil))

0 commit comments

Comments
 (0)