tcp_server: Close socket before calling the disconnection_callback

fmauch · fmauch · commit 4a286db0ba86 · 2021-03-26T11:07:57.000+01:00
diff --git a/src/comm/tcp_server.cpp b/src/comm/tcp_server.cpp
@@ -247,11 +247,11 @@ void TCPServer::spin()
 void TCPServer::handleDisconnect(const int fd)
 {
   URCL_LOG_DEBUG("%d disconnected.", fd);
+  close(fd);
   if (disconnect_callback_)
   {
     disconnect_callback_(fd);
   }
-  close(fd);
   FD_CLR(fd, &masterfds_);
 
   for (size_t i = 0; i < client_fds_.size(); ++i)

Original file line number	Diff line number	Diff line change
`@@ -247,11 +247,11 @@ void TCPServer::spin()`
`247`	`247`	`void TCPServer::handleDisconnect(const int fd)`
`248`	`248`	`{`
`249`	`249`	`URCL_LOG_DEBUG("%d disconnected.", fd);`
	`250`	`+ close(fd);`
`250`	`251`	`if (disconnect_callback_)`
`251`	`252`	`{`
`252`	`253`	`disconnect_callback_(fd);`
`253`	`254`	`}`
`254`		`- close(fd);`
`255`	`255`	`FD_CLR(fd, &masterfds_);`
`256`	`256`
`257`	`257`	`for (size_t i = 0; i < client_fds_.size(); ++i)`