Skip to content

Commit 88eda71

Browse files
yishai1999dkalowsk
authored andcommitted
gpio: adopt SHELL_HELP
Adopt SHELL_HELP macro for gpio_shell Signed-off-by: Yishai Jaffe <[email protected]>
1 parent e572e8f commit 88eda71

File tree

1 file changed

+20
-24
lines changed

1 file changed

+20
-24
lines changed

drivers/gpio/gpio_shell.c

Lines changed: 20 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -645,35 +645,31 @@ static int cmd_gpio_info(const struct shell *sh, size_t argc, char **argv)
645645
return 0;
646646
}
647647

648-
SHELL_STATIC_SUBCMD_SET_CREATE(sub_gpio,
649-
SHELL_CMD_ARG(conf, &sub_gpio_dev,
650-
"Configure GPIO pin\n"
651-
"Usage: gpio conf <device> <pin> <configuration <i|o>[u|d][h|l][0|1]> [vendor specific]\n"
652-
"<i|o> - input|output\n"
653-
"[u|d] - pull up|pull down, otherwise open\n"
654-
"[h|l] - active high|active low, otherwise defaults to active high\n"
655-
"[0|1] - initialise to logic 0|logic 1, otherwise defaults to logic 0\n"
656-
"[vendor specific] - configuration flags within the mask 0xFF00\n"
657-
" see include/zephyr/dt-bindings/gpio/",
648+
SHELL_STATIC_SUBCMD_SET_CREATE(
649+
sub_gpio,
650+
SHELL_CMD_ARG(
651+
conf, &sub_gpio_dev,
652+
SHELL_HELP("Configure GPIO pin",
653+
"<device> <pin> <configuration <i|o>[u|d][h|l][0|1]> [vendor specific]\n"
654+
"<i|o> - input|output\n"
655+
"[u|d] - pull up|pull down, otherwise open\n"
656+
"[h|l] - active high|active low, otherwise defaults to active high\n"
657+
"[0|1] - initialise to logic 0|logic 1, otherwise defaults to logic 0\n"
658+
"[vendor specific] - configuration flags within the mask 0xFF00\n"
659+
" see include/zephyr/dt-bindings/gpio/"),
658660
cmd_gpio_conf, 4, 1),
659-
SHELL_CMD_ARG(get, &sub_gpio_dev,
660-
"Get GPIO pin value\n"
661-
"Usage: gpio get <device> <pin>", cmd_gpio_get, 3, 0),
661+
SHELL_CMD_ARG(get, &sub_gpio_dev, SHELL_HELP("Get GPIO pin value", "<device> <pin>"),
662+
cmd_gpio_get, 3, 0),
662663
SHELL_CMD_ARG(set, &sub_gpio_dev,
663-
"Set GPIO pin value\n"
664-
"Usage: gpio set <device> <pin> <level 0|1>", cmd_gpio_set, 4, 0),
664+
SHELL_HELP("Set GPIO pin value", "<device> <pin> <level 0|1>"), cmd_gpio_set,
665+
4, 0),
665666
SHELL_COND_CMD_ARG(CONFIG_GPIO_SHELL_TOGGLE_CMD, toggle, &sub_gpio_dev,
666-
"Toggle GPIO pin\n"
667-
"Usage: gpio toggle <device> <pin>", cmd_gpio_toggle, 3, 0),
668-
SHELL_CMD(devices, NULL,
669-
"List all GPIO devices\n"
670-
"Usage: gpio devices", cmd_gpio_devices),
667+
SHELL_HELP("Toggle GPIO pin", "<device> <pin>"), cmd_gpio_toggle, 3, 0),
668+
SHELL_CMD(devices, NULL, SHELL_HELP("List all GPIO devices", ""), cmd_gpio_devices),
671669
SHELL_COND_CMD_ARG(CONFIG_GPIO_SHELL_BLINK_CMD, blink, &sub_gpio_dev,
672-
"Blink GPIO pin\n"
673-
"Usage: gpio blink <device> <pin>", cmd_gpio_blink, 3, 0),
670+
SHELL_HELP("Blink GPIO pin", "<device> <pin>"), cmd_gpio_blink, 3, 0),
674671
SHELL_COND_CMD_ARG(CONFIG_GPIO_SHELL_INFO_CMD, info, &sub_gpio_dev,
675-
"GPIO Information\n"
676-
"Usage: gpio info [device]", cmd_gpio_info, 1, 1),
672+
SHELL_HELP("GPIO Information", "[device]"), cmd_gpio_info, 1, 1),
677673
SHELL_SUBCMD_SET_END /* Array terminated. */
678674
);
679675

0 commit comments

Comments
 (0)