fix(forge vb): bail when args expected but none provided (#8764)

fix(forge vb): bail when args are expected but none are provided

Author: yash-atreya

crates/verify/src/bytecode.rs

@@ -209,6 +209,10 @@ impl VerifyBytecodeArgs {
             check_explorer_args(source_code.clone())?
         };
 
+        // This fails only when the contract expects constructor args but NONE were provided OR
+        // retrieved from explorer (in case of predeploys).
+        crate::utils::check_args_len(&artifact, &constructor_args)?;
+
         if maybe_predeploy {
             if !self.json {
                 println!(

crates/verify/src/utils.rs

@@ -307,6 +307,21 @@ pub fn check_explorer_args(source_code: ContractMetadata) -> Result<Bytes, eyre:
     }
 }
 
+pub fn check_args_len(
+    artifact: &CompactContractBytecode,
+    args: &Bytes,
+) -> Result<(), eyre::ErrReport> {
+    if let Some(constructor) = artifact.abi.as_ref().and_then(|abi| abi.constructor()) {
+        if !constructor.inputs.is_empty() && args.len() == 0 {
+            eyre::bail!(
+                "Contract expects {} constructor argument(s), but none were provided",
+                constructor.inputs.len()
+            );
+        }
+    }
+    Ok(())
+}
+
 pub async fn get_tracing_executor(
     fork_config: &mut Config,
     fork_blk_num: u64,