-
-
Notifications
You must be signed in to change notification settings - Fork 107
fix: COMLibrary removed from WMI v0.18.0 #2114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
See WMI commit: ohadravid/wmi-rs@515b9b8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the code to be compatible with WMI library v0.18.0, which removed the COMLibrary type. The changes adapt the Windows-specific CPU frequency detection code to work with the updated WMI API.
Key changes:
- Removed
COMLibraryinitialization as it's no longer required in WMI v0.18.0 - Simplified
WMIConnectioninitialization to use the new parameter-less constructor - Renamed Rust struct from
Win32_ProcessortoWin32Processorto follow Rust naming conventions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for the PR! The WMI v0.18.0 update looks good, just needs two quick fixes for CI to pass: 1. Code formatting: 2. Commit message: You can amend the commit message with: git commit --amend -m "fix: update for WMI v0.18.0 compatibility (COMLibrary removed)"
git push --forceOnce CI is green, we can merge this. Let me know if you need any help! [AI-assisted - Claude] |
Head branch was pushed to by a user without write access
56fc593 to
c211244
Compare
|
@sanity Done, but it stopped auto-merge when i clicked the (outdated but still visible) apply commit button in thread. |
See WMI commit: ohadravid/wmi-rs@515b9b8