Skip to content

Conversation

@kustomzone
Copy link

See WMI commit: ohadravid/wmi-rs@515b9b8

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2025

CLA assistant check
All committers have signed the CLA.

@kustomzone kustomzone changed the title COMLibrary removed from WMI v0.18.0 fix: COMLibrary removed from WMI v0.18.0 Nov 19, 2025
@sanity sanity requested a review from Copilot November 19, 2025 15:15
Copilot finished reviewing on behalf of sanity November 19, 2025 15:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the code to be compatible with WMI library v0.18.0, which removed the COMLibrary type. The changes adapt the Windows-specific CPU frequency detection code to work with the updated WMI API.

Key changes:

  • Removed COMLibrary initialization as it's no longer required in WMI v0.18.0
  • Simplified WMIConnection initialization to use the new parameter-less constructor
  • Renamed Rust struct from Win32_Processor to Win32Processor to follow Rust naming conventions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sanity sanity enabled auto-merge November 19, 2025 18:56
@sanity
Copy link
Collaborator

sanity commented Nov 19, 2025

Thanks for the PR! The WMI v0.18.0 update looks good, just needs two quick fixes for CI to pass:

1. Code formatting:
Run cargo fmt to fix the import formatting at crates/core/src/wasm_runtime/runtime.rs:455

2. Commit message:
Update the commit message to follow Conventional Commits format:

fix: update for WMI v0.18.0 compatibility (COMLibrary removed)

You can amend the commit message with:

git commit --amend -m "fix: update for WMI v0.18.0 compatibility (COMLibrary removed)"
git push --force

Once CI is green, we can merge this. Let me know if you need any help!

[AI-assisted - Claude]

auto-merge was automatically disabled November 19, 2025 19:43

Head branch was pushed to by a user without write access

@kustomzone
Copy link
Author

kustomzone commented Nov 19, 2025

@sanity Done, but it stopped auto-merge when i clicked the (outdated but still visible) apply commit button in thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants