* fixed Callback double free problem

* build updates

Author: krauthaufen

build.cmd

@@ -5,7 +5,7 @@ PUSHD %~dp0
 
 IF NOT exist .paket\paket.exe (
 	echo installing paket
-	dotnet tool install Paket --version 6.0.0-alpha014  --tool-path .paket
+	dotnet tool install Paket --tool-path .paket
 )
 
 if NOT exist paket.lock (

build.fsx

@@ -137,12 +137,12 @@ Target.create "Clean" (fun _ ->
 Target.create "Compile" (fun _ ->
     let options (o : DotNet.BuildOptions) =
         let v = sprintf "%d.%d.%d.%s" notes.SemVer.Major notes.SemVer.Minor notes.SemVer.Patch (string notes.SemVer.Build)
-
         { o with 
             Configuration = DotNet.BuildConfiguration.Release
 
             MSBuildParams = 
                 { o.MSBuildParams with 
+                    DisableInternalBinLog = true        
                     Properties = 
                         [
                             "GenerateAssemblyInfo", "true"
@@ -395,6 +395,7 @@ Target.create "RunTest" (fun _ ->
         { (o.WithRedirectOutput false) with
             NoBuild = true
             NoRestore = true
+            MSBuildParams = { o.MSBuildParams with DisableInternalBinLog = true }
             Configuration = DotNet.BuildConfiguration.Release
             Logger = Some "console;verbosity=normal"
         }

build.sh

@@ -2,7 +2,7 @@
 
 if [ ! -f .paket/paket ]; then
     echo installing paket
-    dotnet tool install Paket --version 6.0.0-alpha014  --tool-path .paket
+    dotnet tool install Paket --tool-path .paket
 fi
 
 if [ ! -f paket.lock ]; then

paket.dependencies

@@ -1,11 +1,10 @@
-version 6.0.0-alpha014
 source https://api.nuget.org/v3/index.json
 redirects: off
 storage: none
 framework: auto-detect
 
 nuget FSharp.Core                           >= 4.6.2 lowest_matching: true
-nuget System.Reflection.Emit.Lightweight    ~> 4.6.0
+nuget System.Reflection.Emit.Lightweight    >= 4.6.0 lowest_matching: true
 
 # Tests : intentionally in main group
 nuget FsUnit                                ~> 3.4.1
@@ -23,13 +22,13 @@ nuget Fable.Browser.Dom                     ~> 1.1.0
 group Build
   framework: netstandard2.0
   source https://api.nuget.org/v3/index.json
-  nuget fake-cli ~> 5.16.1
-  nuget Fake.DotNet.Cli ~> 5.16.1
-  nuget Fake.Core.Target ~> 5.16.1
-  nuget Fake.DotNet.Paket ~> 5.16.1
-  nuget Fake.Core.ReleaseNotes ~> 5.16.1
-  nuget Fake.Tools.Git ~> 5.16.1
-  nuget Fake.Api.GitHub ~> 5.16.1
+  nuget fake-cli ~> 5.19.1
+  nuget Fake.DotNet.Cli ~> 5.19.1
+  nuget Fake.Core.Target ~> 5.19.1
+  nuget Fake.DotNet.Paket ~> 5.19.1
+  nuget Fake.Core.ReleaseNotes ~> 5.19.1
+  nuget Fake.Tools.Git ~> 5.19.1
+  nuget Fake.Api.GitHub ~> 5.19.1
 
 group Docs
   framework: net461

paket.lock

@@ -2,6 +2,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
+    <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
     <OutputPath>..\..\bin\Release\</OutputPath>

src/CSharp.Data.Adaptive/CSharp.Data.Adaptive.fsproj

@@ -2,7 +2,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>netcoreapp3.0</TargetFramework>
+    <LangVersion>8</LangVersion>
+    <TargetFramework>netcoreapp3.1</TargetFramework>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
     <OutputPath>..\..\..\bin\Release\</OutputPath>

src/Demo/CSharpInterop/CSharpInterop.csproj

@@ -2,7 +2,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>netcoreapp3.0</TargetFramework>
+    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
     <OutputPath>..\..\..\bin\Debug\</OutputPath>

src/Demo/EventInterop/EventInterop.fsproj

@@ -2,7 +2,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>netcoreapp3.0</TargetFramework>
+    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
     <OutputPath>..\..\..\bin\Release\</OutputPath>

src/Demo/Fable/Fable.fsproj

@@ -50,15 +50,21 @@ type internal MultiCallbackObject(table : ConditionalWeakTable<IAdaptiveObject,
 
             cbs <- HashMap.add i cb cbs
 
+            #if !FABLE_COMPILER
             let mutable self = Unchecked.defaultof<GCHandle>
             let result = 
                 { new IDisposable with 
                     member __.Dispose() = 
-                        self.Free()
+                        if self.IsAllocated then self.Free()
                         remove x i 
                 }
             self <- GCHandle.Alloc(result)
             result
+            #else
+            { new IDisposable with 
+                member __.Dispose() = remove x i 
+            }
+            #endif
 
         )