Skip to content

Commit bf4066c

Browse files
committed
SynchronousFunctionNames: put message into Text.resx
Put error message into resources file Text.resx.
1 parent 3ef798b commit bf4066c

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/FSharpLint.Core/Rules/Conventions/SynchronousFunctionNames.fs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ let (|ReturnsTask|ReturnsAsync|ReturnsNonAsync|) (returnInfo: SynBindingReturnIn
2929
| _ -> ReturnsNonAsync
3030

3131
let runner (args: AstNodeRuleParams) =
32-
let emitWarning range newFunctionName =
32+
let emitWarning range (newFunctionName: string) =
3333
Array.singleton
3434
{
3535
Range = range
36-
Message = $"This function does not return Async or Task. Consider naming it {newFunctionName}"
36+
Message = String.Format(Resources.GetString "RulesSynchronousFunctionNames", newFunctionName)
3737
SuggestedFix = None
3838
TypeChecks = List.empty
3939
}

src/FSharpLint.Core/Text.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -408,4 +408,7 @@
408408
<data name="RulesFavourNamedMembers" xml:space="preserve">
409409
<value>Use named discriminated union fields.</value>
410410
</data>
411+
<data name="RulesSynchronousFunctionNames" xml:space="preserve">
412+
<value>This function does not return Async or Task. Consider naming it {0}</value>
413+
</data>
411414
</root>

0 commit comments

Comments
 (0)