improve unimport intention. Invoke action inside php doc comments

Author: Ivan Scherbak

META-INF/plugin.xml

@@ -10,6 +10,9 @@
     ]]></description>
 
     <change-notes><![CDATA[
+        <h4>[unreleased]</h4>
+            - [Unimport class] invoke action inside php doc comments
+
         <h4>0.0.2</h4>
             - [Find magic methods] run task in background
             - [Find magic methods] Find magic properties

src/com/funivan/phpstorm/refactoring/UnimportClass/UnimportClassIntention.java

@@ -10,13 +10,14 @@
 import com.jetbrains.php.lang.psi.PhpPsiElementFactory;
 import com.jetbrains.php.lang.psi.elements.ClassReference;
 import com.jetbrains.php.lang.psi.elements.PhpPsiElement;
+import com.jetbrains.php.lang.psi.elements.PhpReference;
 import com.jetbrains.php.lang.psi.elements.PhpUse;
 import com.jetbrains.php.lang.psi.visitors.PhpRecursiveElementVisitor;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
 /**
- * Created by ivan on 19.01.16.
+ * Created by funivan
  */
 public class UnimportClassIntention extends PsiElementBaseIntentionAction {
 
@@ -56,17 +57,23 @@ public boolean isAvailable(@NotNull Project project, Editor editor, @Nullable Ps
         }
 
         PsiElement baseElement = element.getParent();
-        if (!(baseElement instanceof ClassReference)) {
+
+        if (!(baseElement instanceof PhpReference)) {
+            return false;
+        }
+        PhpReference ref = (PhpReference) baseElement;
+
+        if (ref.isAbsolute()) {
             return false;
         }
 
-        String fqn = ((ClassReference) baseElement).getFQN();
+        String fqn = ref.getFQN();
 
-        if (fqn.equals(baseElement.getText())) {
+        if (fqn == null) {
             return false;
         }
 
-        return true;
+        return !fqn.equals(baseElement.getText());
     }
 
     /**
@@ -78,14 +85,22 @@ public boolean isAvailable(@NotNull Project project, Editor editor, @Nullable Ps
      */
     public void invoke(@NotNull Project project, Editor editor, @NotNull PsiElement element) {
         element = element.getParent();
-        ClassReference classReference = (ClassReference) element;
+        if (!(element instanceof PhpReference)) {
+            return;
+        }
+        PhpReference classReference = (PhpReference) element;
 
         PhpPsiElement scopeForUseOperator = PhpCodeInsightUtil.findScopeForUseOperator(classReference);
 
-        assert scopeForUseOperator != null;
+        if (scopeForUseOperator == null) {
+            return;
+        }
 
 
         String fqn = classReference.getFQN();
+        if (fqn == null) {
+            return;
+        }
         ClassReference newClassRef = PhpPsiElementFactory.createClassReference(project, fqn);
 
 
@@ -99,7 +114,7 @@ public void visitPhpElement(PhpPsiElement element) {
 
             public void visitPhpDocType(PhpDocType phpDocType) {
 
-                if (phpDocType.isAbsolute() == true) {
+                if (phpDocType.isAbsolute()) {
                     return;
                 }