Rewrite conversion.py

[schwehr]

It would be good to rewrite conversion.py based on syntax trees with proper parsers for python and javascript. On the python side, that would be the ast module. I'm sure there are similar tools on the JavaScript side.

I think it might also be good to have the conversion system be in a totally separate package that geemap depends on.

Right now, the conversion module only depends on a few things from geemap and only from coreutils: random_string and temp_file_path

geemap/geemap/conversion.py

Line 23 in 683ac42

from . import coreutils

And example of using python's ast module: https://github.com/asottile/pyupgrade

[AmitaWhite]

I like to work on this issue! Could you please assign this to me?

[AmitaWhite]

Hi, I just wanted to give a quick update. I'm still working on this issue. I’ve been exploring the ast module and esprima to implement the new parser. It’s taking a bit of time to map correctly, but I'm making progress. I’ll share a draft PR or more details soon!

Sorry to late..!

[AmitaWhite]

Hi, thanks for assigning this issue to me.

I spent some time exploring the codebase and tried using the Python esprima
module to parse the JavaScript AST. I was also able to get a partial
understanding of the AST structure itself.

However, I’m currently struggling with understanding the full scope of the
existing conversion.py implementation, and I’m not confident about how the
test cases are supposed to be run and validated in this project.

At this point, I feel I lack enough context to make meaningful progress, and I
don’t want to block the issue for others. So I think it would be best for me to
step back and unassign myself for now.

Sorry about that, and thank you for your understanding.

[schwehr]

Thank you for taking a look and no worries. You might consider making a separate repo and creating a conversion library that meets your own expectations and tests. They you have the freedom to make progress towards a tool that people might find useful on its own.

If you have any thoughts on what you discovered during the process and are willing to share, please do.

[bruno-portfolio]

Hi @schwehr,

I'd like to help with this but i've a few questions:

Should the AST rewrite cover both JS→Python and Python→JS, or start with one direction?
For the JS side, any preference on parser? (esprima, pyjsparser, etc.)
Should the separate package PR come first, or the AST rewrite?

Happy to start with a small proof-of-concept for one conversion function.