Fix a few clippy lints (#340)

Author: aljazerzen

.github/workflows/test.yml

@@ -9,6 +9,7 @@ jobs:
     strategy:
       matrix:
         rust_version: [default, minimum, beta]
+      fail-fast: false
     timeout-minutes: 30
     permissions:
       id-token: "write"

edgedb-protocol/src/client_message.rs

@@ -27,7 +27,6 @@ pub enum ClientMessage {
 
 use std::collections::HashMap;
 use std::convert::TryFrom;
-use std::u16;
 
 use bytes::{Buf, BufMut, Bytes};
 use snafu::{ensure, OptionExt};

edgedb-protocol/src/encoding.rs

@@ -1,7 +1,6 @@
 use std::collections::HashMap;
 use std::convert::TryFrom;
 use std::ops::{Deref, DerefMut, RangeBounds};
-use std::u32;
 
 use bytes::{Buf, BufMut, Bytes, BytesMut};
 use snafu::{ensure, OptionExt, ResultExt};

edgedb-protocol/src/model/json.rs

@@ -9,12 +9,12 @@ impl Json {
     /// Two examples of use:
     ///
     /// 1) To construct values with the data received from the
-    /// database, because we trust database to produce valid JSON.
+    ///    database, because we trust database to produce valid JSON.
     ///
     /// 2) By client users who are using data that is guaranteed
-    /// to be valid JSON. If unsure, using a method such as serde_json's
-    /// [to_string](https://docs.rs/serde_json/latest/serde_json/ser/fn.to_string.html) to
-    /// construct a String is highly recommended.
+    ///    to be valid JSON. If unsure, using a method such as serde_json's
+    ///    [to_string](https://docs.rs/serde_json/latest/serde_json/ser/fn.to_string.html)
+    ///    to construct a String is highly recommended.
     ///
     /// When used in a client query method, EdgeDB itself will recognize if the
     /// String inside `Json` is invalid JSON by returning `InvalidValueError:

edgedb-protocol/src/model/time.rs

@@ -985,10 +985,7 @@ mod test {
         assert_eq!(Src { micros: -1000 }.abs_duration(), Trg::new(0, 1000000));
         assert_eq!(Src { micros: -1000000 }.abs_duration(), Trg::new(1, 0));
         assert_eq!(
-            Src {
-                micros: i64::min_value()
-            }
-            .abs_duration(),
+            Src { micros: i64::MIN }.abs_duration(),
             Trg::new(9223372036854, 775808000)
         );
     }

edgedb-protocol/src/server_message.rs

@@ -27,8 +27,6 @@ pub enum ServerMessage {
 
 use std::collections::HashMap;
 use std::convert::{TryFrom, TryInto};
-use std::u16;
-use std::u32;
 
 use bytes::{Buf, BufMut, Bytes};
 use snafu::{ensure, OptionExt};

edgedb-protocol/src/value.rs

@@ -105,6 +105,7 @@ impl SparseObject {
     /// Note: this method has two limitations:
     /// 1. Shape created uses `AtMostOne` cardinality for all the elements.
     /// 2. There are no extra shape elements
+    ///
     /// Both of these are irrelevant when serializing the object.
     pub fn from_pairs<N: ToString, V: Into<Option<Value>>>(
         iter: impl IntoIterator<Item = (N, V)>,

edgedb-protocol/tests/codecs.rs

@@ -3,7 +3,6 @@ extern crate pretty_assertions;
 
 use std::error::Error;
 use std::sync::Arc;
-use std::{i16, i32, i64};
 
 use bytes::Bytes;