fixup

Author: quangx

source/simulator/solver.cc

@@ -386,6 +386,13 @@ namespace aspect
         virtual unsigned int n_iterations() const=0;
 
     };
+
+
+    /**
+     * Given a diagonal matrix stored as a vector, 
+     * create an operator that represents its action.
+    */
+    
     template<typename Range,
              typename Domain,
              typename Payload>
@@ -402,10 +409,11 @@ namespace aspect
         dest = src;
         dest.scale(diagonal);
       };
-      //  std::cout << "ok" << std::endl;
       return return_op;
     }
 
+
+
     /**
      * This class approximates the Schur Complement inverse operator
      * by S^{-1} = (BC^{-1}B^T)^{-1}(BC^{-1}AD^{-1}B^T)(BD^{-1}B^T)^{-1},
@@ -483,11 +491,11 @@ namespace aspect
             SolverControl solver_control(5000, 1e-6 * src.l2_norm(), false, true);
             SolverCG<TrilinosWrappers::MPI::Vector> solver(solver_control);
             //Solve with Schur Complement approximation
-            auto Op_A=LinearOperator<TrilinosWrappers::MPI::Vector>(system_matrix.block(0,0));
-            auto Op_BT = LinearOperator<TrilinosWrappers::MPI::Vector>(system_matrix.block(0,1));
-            auto Op_B = LinearOperator<TrilinosWrappers::MPI::Vector>(system_matrix.block(1,0));
-            auto Op_C = diag_operator(Op_A,inverse_lumped_mass_matrix);
-            auto matrix = Op_B*Op_C*Op_BT;
+            const auto Op_A      = LinearOperator<TrilinosWrappers::MPI::Vector>(system_matrix.block(0,0));
+            const auto Op_BT     = LinearOperator<TrilinosWrappers::MPI::Vector>(system_matrix.block(0,1));
+            const auto Op_B      = LinearOperator<TrilinosWrappers::MPI::Vector>(system_matrix.block(1,0));
+            const auto Op_C_inv  = diag_operator(Op_A,inverse_lumped_mass_matrix);
+            const auto BC_invBT  = Op_B*Op_C_inv*Op_BT;
 
 
 
@@ -504,7 +512,7 @@ namespace aspect
             system_matrix.block(1,0).vmult(ptmp,wtmp);
 
             dst=0;
-            solver.solve(matrix,
+            solver.solve(BC_invBT,
                          dst,
                          ptmp,
                          mp_preconditioner);