There is logic in the Watchdog script to kill GeoServer processes in case is still running after the stop command. I this really a good idea?
Packaged versions of Apache Tomcat ship with their own init script with their own implementation of the stop command that kill the process if needed and are, of course, aware of the specifics of the distribution that is running Tomcat ( systemd vs upstart, location of the PID file, ecc... )
I don't think that is the Watchdog responsibility to do this, bypassing the Init scripts and knowing all about the details of how the process is started and stopped. Furthermore this adds complexity to the script itself, I suggest we remove that code from the script. Opinions?
There is logic in the Watchdog script to
killGeoServer processes in case is still running after the stop command. I this really a good idea?Packaged versions of Apache Tomcat ship with their own init script with their own implementation of the stop command that kill the process if needed and are, of course, aware of the specifics of the distribution that is running Tomcat ( systemd vs upstart, location of the PID file, ecc... )
I don't think that is the Watchdog responsibility to do this, bypassing the Init scripts and knowing all about the details of how the process is started and stopped. Furthermore this adds complexity to the script itself, I suggest we remove that code from the script. Opinions?